Evolution-x-devices/device_google_taimen
2
0
Fork 0
mirror of https://github.com/Evolution-X-Devices/device_google_taimen synced 2026-01-27 22:46:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary sysprop settings

Browse Source 
These debuf.sf.early_* properties have been inactive because they are
all eclipsed by the settings in wahoo/device.mk. Specifically,

// wahoo/device.mk
PRODUCT_PROPERTY_OVERRIDES := a=10

// taimen/device.mk
include wahoo/device.mk
PRODUCT_PROPERTY_OVERRIDES += a=20

With above, PRODUCT_PROPERTY_OVERRIDES becomes "a=10 a=20" and the build
system has chosen "a=10" via the uniq-pairs-by-first-component macro.
This was  because PRODUCT_* lists were designed with an assumption that
those mk files are inherited (without being included) in which case the
values from more specific *.mk file are 'prepended' (not appaended).

Since the settings in taimen/device.mk has been obsolete, let's remove
them. This problem was actually found with
I9c073a21c8257987cf2378012cadaeeeb698a4fb where duplicated sysprop
assignments are prohibited, which is an attempt to make the sysprop
settings be agnostic to the confusing ordering behavior imposed by the
product inheritance mechanism.

Bug: 117892318
Bug: 158735147
Test: m

Exempt-From-Owner-Approval: cherry-pick master

Merged-In: I6d1dd46edba0ad69586791935fca0da484ef2746
(cherry picked from commit 695f1fbe29f2ea08ed3a5cefb0fa487bea9144f4)
Change-Id: I6d1dd46edba0ad69586791935fca0da484ef2746
This commit is contained in:
Jiyong Park
2020-06-23 15:35:26 +09:00
parent 16fd1c3a2d
commit 4744ee6eb6
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
device.mk
View File

@@ -137,12 +137,3 @@ PRODUCT_PROPERTY_OVERRIDES += \
ro.vibrator.hal.tick.duration=4 \
ro.vibrator.hal.heavyclick.duration=12
# Early phase offset for SurfaceFlinger (b/75985430)
PRODUCT_PROPERTY_OVERRIDES += \
debug.sf.early_phase_offset_ns=1500000
PRODUCT_PROPERTY_OVERRIDES += \
debug.sf.early_app_phase_offset_ns=500000
PRODUCT_PROPERTY_OVERRIDES += \
debug.sf.early_gl_phase_offset_ns=1500000
PRODUCT_PROPERTY_OVERRIDES += \
debug.sf.early_gl_app_phase_offset_ns=15000000