Peter Zijlstra 50013eadda mm/uaccess: Use 'unsigned long' to placate UBSAN warnings on older GCC versions ...

[ Upstream commit 29da93fea3ea39ab9b12270cc6be1b70ef201c9e ]

Randy reported objtool triggered on his (GCC-7.4) build:

  lib/strncpy_from_user.o: warning: objtool: strncpy_from_user()+0x315: call to __ubsan_handle_add_overflow() with UACCESS enabled
  lib/strnlen_user.o: warning: objtool: strnlen_user()+0x337: call to __ubsan_handle_sub_overflow() with UACCESS enabled

This is due to UBSAN generating signed-overflow-UB warnings where it
should not. Prior to GCC-8 UBSAN ignored -fwrapv (which the kernel
uses through -fno-strict-overflow).

Make the functions use 'unsigned long' throughout.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: luto@kernel.org
Link: http://lkml.kernel.org/r/20190424072208.754094071@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2019-05-31 06:48:17 -07:00

..

842

…

fonts

…

lz4

lz4: fix bogus gcc warning

2017-09-02 07:07:54 +02:00

lzo

…

mpi

lib/mpi: Fix umul_ppmm() for MIPS64r6

2018-03-03 10:23:23 +01:00

raid6

ARM: 8833/1: Ensure that NEON code always compiles with Clang

2019-04-05 22:29:11 +02:00

reed_solomon

…

xz

…

zlib_deflate

…

zlib_inflate

…

.gitignore

…

argv_split.c

…

asn1_decoder.c

ASN.1: check for error from ASN1_OP_END__ACT actions

2017-12-14 09:28:12 +01:00

assoc_array.c

assoc_array: Fix shortcut creation

2019-03-23 13:19:42 +01:00

atomic64_test.c

…

atomic64.c

…

audit.c

…

bcd.c

…

bch.c

…

bitmap.c

…

bitrev.c

…

bsearch.c

kprobes: Prohibit probing on bsearch()

2019-04-05 22:29:11 +02:00

btree.c

…

bug.c

…

build_OID_registry

…

bust_spinlocks.c

…

chacha20.c

…

check_signature.c

…

checksum.c

…

clz_ctz.c

…

clz_tab.c

…

cmdline.c

lib/cmdline.c: fix get_options() overflow while parsing ranges

2017-06-29 13:00:28 +02:00

compat_audit.c

…

cordic.c

…

cpu_rmap.c

…

cpu-notifier-error-inject.c

…

cpumask.c

sched/fair, cpumask: Export for_each_cpu_wrap()

2017-07-21 07:42:23 +02:00

crc7.c

…

crc8.c

…

crc16.c

…

crc32.c

…

crc32defs.h

…

crc-ccitt.c

…

crc-itu-t.c

…

crc-t10dif.c

…

ctype.c

…

debug_info.c

…

debug_locks.c

locking/lockdep: Fix debug_locks off performance problem

2018-11-13 11:16:48 -08:00

debugobjects.c

debugobjects: avoid recursive calls with kmemleak

2018-12-17 09:38:35 +01:00

dec_and_lock.c

…

decompress_bunzip2.c

…

decompress_inflate.c

…

decompress_unlz4.c

…

decompress_unlzma.c

…

decompress_unlzo.c

…

decompress_unxz.c

…

decompress.c

…

devres.c

…

digsig.c

lib/digsig: fix dereference of NULL user_key_payload

2017-10-27 10:38:08 +02:00

div64.c

lib/div64.c: off by one in shift

2019-04-20 09:07:54 +02:00

dma-debug.c

…

dma-noop.c

…

dump_stack.c

…

dynamic_debug.c

dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0

2017-12-14 09:28:22 +01:00

dynamic_queue_limits.c

…

earlycpio.c

…

extable.c

…

fault-inject.c

…

fdt_empty_tree.c

…

fdt_ro.c

…

fdt_rw.c

…

fdt_strerror.c

…

fdt_sw.c

…

fdt_wip.c

…

fdt.c

…

find_bit.c

…

flex_array.c

…

flex_proportions.c

…

gcd.c

…

gen_crc32table.c

…

genalloc.c

lib/genalloc.c: make the avail variable an atomic_long_t

2017-12-14 09:28:22 +01:00

glob.c

…

halfmd4.c

…

hexdump.c

…

hweight.c

…

idr.c

…

inflate.c

…

int_sqrt.c

lib/int_sqrt: optimize initial value compute

2019-04-05 22:29:04 +02:00

interval_tree_test.c

lib/interval_tree_test.c: allow users to limit scope of endpoint

2018-12-21 14:11:30 +01:00

interval_tree.c

…

iomap_copy.c

…

iomap.c

…

iommu-common.c

…

iommu-helper.c

…

ioremap.c

ioremap: Update pgtable free interfaces with addr

2018-08-17 20:59:29 +02:00

iov_iter.c

new privimitive: iov_iter_revert()

2017-04-21 09:31:21 +02:00

irq_poll.c

…

irq_regs.c

…

is_single_threaded.c

…

jedec_ddr_data.c

…

kasprintf.c

…

Kconfig

…

Kconfig.debug

kasan: rework Kconfig settings

2018-02-25 11:05:55 +01:00

Kconfig.kasan

…

Kconfig.kgdb

…

Kconfig.kmemcheck

…

Kconfig.ubsan

…

kfifo.c

…

klist.c

scsi: klist: Make it safe to use klists in atomic context

2018-10-03 17:01:45 -07:00

kobject_uevent.c

…

kobject.c

kobject: Replace strncpy with memcpy

2018-12-08 13:05:05 +01:00

kstrtox.c

…

kstrtox.h

…

lcm.c

…

libcrc32c.c

crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-24 07:11:17 +02:00

list_debug.c

…

list_sort.c

…

llist.c

…

locking-selftest-hardirq.h

…

locking-selftest-mutex.h

…

locking-selftest-rlock-hardirq.h

…

locking-selftest-rlock-softirq.h

…

locking-selftest-rlock.h

…

locking-selftest-rsem.h

…

locking-selftest-softirq.h

…

locking-selftest-spin-hardirq.h

…

locking-selftest-spin-softirq.h

…

locking-selftest-spin.h

…

locking-selftest-wlock-hardirq.h

…

locking-selftest-wlock-softirq.h

…

locking-selftest-wlock.h

…

locking-selftest-wsem.h

…

locking-selftest.c

…

lockref.c

…

lru_cache.c

…

Makefile

kasan: prevent compiler from optimizing away memset in tests

2019-05-08 07:19:07 +02:00

md5.c

…

memory-notifier-error-inject.c

…

memweight.c

…

net_utils.c

…

netdev-notifier-error-inject.c

…

nlattr.c

…

nmi_backtrace.c

…

nodemask.c

…

notifier-error-inject.c

…

notifier-error-inject.h

…

of-reconfig-notifier-error-inject.c

…

oid_registry.c

509: fix printing uninitialized stack memory when OID is empty

2018-02-25 11:05:48 +01:00

once.c

…

parser.c

…

pci_iomap.c

…

percpu_counter.c

…

percpu_ida.c

…

percpu_test.c

…

percpu-refcount.c

…

plist.c

…

pm-notifier-error-inject.c

…

radix-tree.c

Revert "radix tree test suite: fix compilation"

2016-12-09 10:41:42 -08:00

random32.c

…

ratelimit.c

lib/ratelimit.c: use deferred printk() version

2017-10-12 11:51:19 +02:00

rational.c

…

rbtree_test.c

lib/rbtree-test: lower default params

2018-12-21 14:11:30 +01:00

rbtree.c

…

reciprocal_div.c

…

rhashtable.c

rhashtable: add schedule points

2018-10-18 09:13:24 +02:00

sbitmap.c

…

scatterlist.c

…

seq_buf.c

seq_buf: Make seq_buf_puts() null-terminate the buffer

2019-02-12 19:44:57 +01:00

sg_pool.c

…

sg_split.c

…

sha1.c

…

show_mem.c

…

smp_processor_id.c

…

sort.c

…

stackdepot.c

…

stmp_device.c

…

string_helpers.c

…

string.c

lib/string.c: implement a basic bcmp

2019-04-17 08:36:39 +02:00

strncpy_from_user.c

mm/uaccess: Use 'unsigned long' to placate UBSAN warnings on older GCC versions

2019-05-31 06:48:17 -07:00

strnlen_user.c

mm/uaccess: Use 'unsigned long' to placate UBSAN warnings on older GCC versions

2019-05-31 06:48:17 -07:00

swiotlb.c

swiotlb: clean up reporting

2018-12-13 09:20:29 +01:00

syscall.c

lib/syscall: Clear return values when no stack

2017-04-08 09:30:35 +02:00

test_bitmap.c

…

test_bpf.c

test_bpf: Fix testing with CONFIG_BPF_JIT_ALWAYS_ON=y on other arches

2018-11-10 07:42:54 -08:00

test_firmware.c

…

test_hash.c

…

test_hexdump.c

test_hexdump: use memcpy instead of strncpy

2018-12-08 13:05:04 +01:00

test_kasan.c

kasan: remove redundant initialization of variable 'real_size'

2019-05-08 07:19:07 +02:00

test_module.c

…

test_printf.c

…

test_rhashtable.c

…

test_static_key_base.c

…

test_static_keys.c

…

test_user_copy.c

usercopy: Adjust tests to deal with SMAP/PAN

2017-06-14 15:06:05 +02:00

test_uuid.c

…

test-kstrtox.c

…

test-string_helpers.c

…

textsearch.c

…

timerqueue.c

…

ts_bm.c

…

ts_fsm.c

…

ts_kmp.c

…

ubsan.c

ubsan: Fix nasty -Wbuiltin-declaration-mismatch GCC-9 warnings

2019-05-10 17:52:07 +02:00

ubsan.h

lib/ubsan: add type mismatch handler for new GCC/Clang

2018-02-17 13:21:20 +01:00

ucs2_string.c

…

uuid.c

…

vsprintf.c

lib/vsprintf: Remove atomic-unsafe support for %pCr

2018-07-03 11:23:06 +02:00

win_minmax.c

…