From 1026647fddfc2935c7ff679a7f4daa2ad85ada87 Mon Sep 17 00:00:00 2001 From: Rakesh Kota Date: Fri, 4 Nov 2022 11:31:26 +0530 Subject: [PATCH] ARM: dts: msm: update regulators for ravelin Add "qcom,disable-mode" property for all LDOs to prevent the case of any LDO remaining in HPM if disabled and never voted to LPM from HLOS.Update PM8008 regulator name to PM8010. PM8010 PMOS LDOs (i.e. LDOs 3-7 )do not support LPM, using it leads to no power efficiency improvements, and using it can cause false-positive OCP triggering, disallow mode control for PM8010 LDOs 3-7. Rely on the hardware default NPM configuration for these LDOs instead. Change-Id: If9a459f32d51c4680f9cf058ec5b56505cf3da6b --- qcom/ravelin-regulators.dtsi | 81 ++++++++++++++++++++---------------- 1 file changed, 44 insertions(+), 37 deletions(-) diff --git a/qcom/ravelin-regulators.dtsi b/qcom/ravelin-regulators.dtsi index b9066b56..ed4d016a 100644 --- a/qcom/ravelin-regulators.dtsi +++ b/qcom/ravelin-regulators.dtsi @@ -120,6 +120,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L1B: pm6450_l1: regulator-pm6450-l1 { regulator-name = "pm6450_l1"; @@ -155,6 +156,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L3B: pm6450_l3: regulator-pm6450-l3 { regulator-name = "pm6450_l3"; @@ -174,6 +176,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L4B: pm6450_l4: regulator-pm6450-l4 { regulator-name = "pm6450_l4"; @@ -193,6 +196,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L5B: pm6450_l5: regulator-pm6450-l5 { regulator-name = "pm6450_l4"; @@ -212,6 +216,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L6B: pm6450_l6: regulator-pm6450-l6 { regulator-name = "pm6450_l6"; @@ -231,6 +236,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L7B: pm6450_l7: regulator-pm6450-l7 { regulator-name = "pm6450_l7"; @@ -266,6 +272,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L9B: pm6450_l9: regulator-pm6450-l9 { regulator-name = "pm6450_l9"; @@ -285,6 +292,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L10B: pm6450_l10: regulator-pm6450-l10 { regulator-name = "pm6450_l10"; @@ -304,6 +312,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L11B: pm6450_l11: regulator-pm6450-l11 { regulator-name = "pm6450_l11"; @@ -322,6 +331,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L12B: pm6450_l12: regulator-pm6450-l12 { regulator-name = "pm6450_l12"; @@ -341,6 +351,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L13B: pm6450_l13: regulator-pm6450-l13 { regulator-name = "pm6450_l13"; @@ -360,6 +371,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L14B: pm6450_l14: regulator-pm6450-l14 { regulator-name = "pm6450_l14"; @@ -379,6 +391,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L16B: pm6450_l16: regulator-pm6450-l16 { regulator-name = "pm6450_l16"; @@ -398,6 +411,7 @@ ; qcom,mode-threshold-currents = <0 30000>; + qcom,disable-mode = ; L17B: pm6450_l17: regulator-pm6450-l17 { regulator-name = "pm6450_l17"; @@ -417,6 +431,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L18B: pm6450_l18: regulator-pm6450-l18 { regulator-name = "pm6450_l18"; @@ -436,6 +451,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L19B: pm6450_l19: regulator-pm6450-l19 { regulator-name = "pm6450_l19"; @@ -455,6 +471,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L20B: pm6450_l20: regulator-pm6450-l20 { regulator-name = "pm6450_l20"; @@ -474,6 +491,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L21B: pm6450_l21: regulator-pm6450-l21 { regulator-name = "pm6450_l21"; @@ -493,6 +511,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L22B: pm6450_l22: regulator-pm6450-l22 { regulator-name = "pm6450_l22"; @@ -512,6 +531,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L23B: pm6450_l23: regulator-pm6450-l23 { regulator-name = "pm6450_l23"; @@ -523,7 +543,7 @@ }; }; - rpmh-regulator-ldoe24 { + rpmh-regulator-ldob24 { compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldob24"; qcom,regulator-type = "pmic5-ldo"; @@ -531,6 +551,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L24B: pm6450_l24: regulator-pm6450-l24 { regulator-name = "pm6450_l24"; @@ -550,6 +571,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L25B: pm6450_l25: regulator-pm6450-l25 { regulator-name = "pm6450_l25"; @@ -569,6 +591,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L26B: pm6450_l26: regulator-pm6450-l26 { regulator-name = "pm6450_l26"; @@ -588,6 +611,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L27B: pm6450_l27: regulator-pm6450-l27 { regulator-name = "pm6450_l27"; @@ -607,6 +631,7 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L28B: pm6450_l28: regulator-pm6450-l28 { regulator-name = "pm6450_l28"; @@ -626,9 +651,10 @@ ; qcom,mode-threshold-currents = <0 10000>; + qcom,disable-mode = ; L1E: - pm8008l_l1: regulator-pm8008-l1 { - regulator-name = "pm8008_l1"; + pm8010l_l1: regulator-pm8010-l1 { + regulator-name = "pm8010_l1"; qcom,set = ; regulator-min-microvolt = <530000>; regulator-max-microvolt = <864000>; @@ -640,13 +666,10 @@ compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldoe3"; qcom,regulator-type = "pmic5-ldo"; - qcom,supported-modes = - ; - qcom,mode-threshold-currents = <0 10000>; + /* mode voting is not allowed */ L3E: - pm8008l_l3: regulator-pm8008-l3 { - regulator-name = "pm8008_l3"; + pm8010l_l3: regulator-pm8010-l3 { + regulator-name = "pm8010_l3"; qcom,set = ; regulator-min-microvolt = <2700000>; regulator-max-microvolt = <3300000>; @@ -658,18 +681,14 @@ compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldoe4"; qcom,regulator-type = "pmic5-ldo"; - qcom,supported-modes = - ; - qcom,mode-threshold-currents = <0 10000>; + /* mode voting is not allowed */ L4E: - pm8008_l4: regulator-pm8008-l4 { - regulator-name = "pm8008_l4"; + pm8010_l4: regulator-pm8010-l4 { + regulator-name = "pm8010_l4"; qcom,set = ; regulator-min-microvolt = <2600000>; regulator-max-microvolt = <3312000>; qcom,init-voltage = <2700000>; - qcom,init-mode = ; }; }; @@ -677,15 +696,11 @@ compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldoe5"; qcom,regulator-type = "pmic5-ldo"; - qcom,supported-modes = - ; - qcom,mode-threshold-currents = <0 10000>; + /* mode voting is not allowed */ L5E: - pm8008_l5: regulator-pm8008-l5 { - regulator-name = "pm8008_l5"; + pm8010_l5: regulator-pm8010-l5 { + regulator-name = "pm8010_l5"; qcom,set = ; - qcom,init-mode = ; /* * Remove min/max voltages for this regulator as initial * voltage of L5E is set to be 2.4v/2.96v during PON @@ -700,18 +715,14 @@ compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldoe6"; qcom,regulator-type = "pmic5-ldo"; - qcom,supported-modes = - ; - qcom,mode-threshold-currents = <0 10000>; + /* mode voting is not allowed */ L6E: - pm8008_l6: regulator-pm8008-l6 { - regulator-name = "pm8008_l6"; + pm8010_l6: regulator-pm8010-l6 { + regulator-name = "pm8010_l6"; qcom,set = ; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3312000>; qcom,init-voltage = <3000000>; - qcom,init-mode = ; }; }; @@ -719,18 +730,14 @@ compatible = "qcom,rpmh-vrm-regulator"; qcom,resource-name = "ldoe7"; qcom,regulator-type = "pmic5-ldo"; - qcom,supported-modes = - ; - qcom,mode-threshold-currents = <0 10000>; + /* mode voting is not allowed */ L7E: - pm8008_l7: regulator-pm8008-l7 { - regulator-name = "pm8008_l7"; + pm8010_l7: regulator-pm8010-l7 { + regulator-name = "pm8010_l7"; qcom,set = ; regulator-min-microvolt = <2500000>; regulator-max-microvolt = <3544000>; qcom,init-voltage = <3000000>; - qcom,init-mode = ; }; };