From a695bcfefd7bee77873258fdc65f84ed8b1be1e0 Mon Sep 17 00:00:00 2001 From: Fenglin Wu Date: Fri, 6 Mar 2020 19:43:44 +0800 Subject: [PATCH] bindings: input: qcom-hv-haptics: Change to use 8-bit FIFO data Hardware with revision 2 is changed to use 8-bit FIFO memory while revision 1 is using 9-bit FIFO memory. To unify the data assignment from devicetree, change to use 8-bit data for "qcom,wf-fifo-data" property. Software can expand the 8-bit data to 9-bit for V1 hardware accordingly. Change-Id: I00749a3cb395bf38ffd4d0cc9fd48de29b949c6d --- bindings/input/qcom-hv-haptics.txt | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/bindings/input/qcom-hv-haptics.txt b/bindings/input/qcom-hv-haptics.txt index c4c1bfe3..8673638c 100644 --- a/bindings/input/qcom-hv-haptics.txt +++ b/bindings/input/qcom-hv-haptics.txt @@ -166,10 +166,11 @@ different vibration effects: - qcom,wf-fifo-data: Usage: optional Value type: - Definition: Defines a 9-bit data array of patterns which will be filled - into the FIFO memory and played when FIFO mode is selected. - The array needs to be specified as 16-bit using '/bits/ 16' - parameter. Either "qcom,wf-pattern-data" or "qcom,wf-fifo-data" + Definition: Defines a byte array of patterns which will be filled into + the FIFO memory and played when FIFO mode is selected. + The array needs to be specified as 8-bit using '/bits/ 8' + parameter, or using '[]' instead of '<>'. + Either "qcom,wf-pattern-data" or "qcom,wf-fifo-data" need to be defined in one effect child node. If both are defined, then the FIFO data defined in this property will be ignored. @@ -254,9 +255,9 @@ Example: /* DOUBLE_CLICK effect */ qcom,effect-id = <1>; qcom,wf-vmax-mv = <5000>; - qcom,wf-fifo-data = /bits/ 16 <0x1ff 0x1ff 0x1ff 0x1ff 0x1ff - 0x1ff 0x1ff 0x1ff 0x1ff 0x1ff - 0x1ff 0x1ff 0x1ff 0x1ff 0x1ff>; + qcom,wf-fifo-data = /bits/ 8 <0xff 0xff 0xff 0xff 0xff + 0xff 0xff 0xff 0xff 0xff + 0xff 0xff 0xff 0xff 0xff>; qcom,wf-fifo-period = ; qcom,wf-brake-pattern = /bits/ 8 <0x7f 0x5f 0x3f>; qcom,wf-auto-res-disable;