Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-09 02:20:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
45de41623079aaa7bb7b1663ce4b599fb16d61c4
hardware_interfaces/graphics/allocator/2.0/utils/passthrough/Android.bp

25 lines
799 B
Plaintext
Raw Normal View History

graphics: make allocator passthrough library header-only android.hardware.graphics.allocator@2.0-passthrough should be a header-only library to be fully reusable by vendor HALs. This also allows us to switch from virtual inheritance to templates, which is more straightforward. This changes nothing to the users and we still have these relations - AllocatorHal is an abstract class to be implemented by vendors or the default implementations - Gralloc[01]Hal are our default implementations - Allocator implements HIDL IAllocator interface on top of AllocatorHal What we do not like about virtual inheritance is that, given // abstract class B and D class B { virtual void foo() = 0; virtual void bar() = 0; }; class D : public virtual B { // foo is superceded by fooEnhanced in D void foo() { fooEnhanced(); } virtual void fooEnhanced() = 0; }; // an implementation of B class BImpl : public virtual B { void foo() {} void bar() {} }; // an implementation of D on top of BImpl class DImpl : public virtual D, public virtual BImpl { void fooEnhanced() {} }; we get "no unique final overrider" becase both D and BImpl implement foo. With non-virtual inheritance, on the other hand, we get "DImpl is abstract" because foo is still pure virtual implemented in DImpl. Templates solve the issue by allowing namespace detail{ template<typename T> class BImpl : public T { ... }; template<typename T> class DImpl : public BImpl<T> { ... }; } // namespace detail using BImpl = detail::BImpl<B>; using DImpl = detail::DImpl<D>; Test: boots Change-Id: Iccb513e4fc751e9a687a1ed2d9fb2192c8324a50
2018-01-19 15:04:17 -08:00
cc_library_headers {
graphics: make allocator default impl a static library Convert the default impl into a static library, android.hardware.graphics.allocator@2.0-passthrough. Test: boots and VTS Change-Id: I8ec8b30766462ecb3fb789af7c6dbb3c088ccf57
2017-12-15 14:41:42 -08:00
name: "android.hardware.graphics.allocator@2.0-passthrough",
defaults: ["hidl_defaults"],
vendor: true,
shared_libs: [
"android.hardware.graphics.allocator@2.0",
"android.hardware.graphics.mapper@2.0",
"libhardware",
],
export_shared_lib_headers: [
"android.hardware.graphics.allocator@2.0",
"android.hardware.graphics.mapper@2.0",
"libhardware",
],
header_libs: [
graphics: use allocator HAL support library in default impl Rename Gralloc0Allocator to Gralloc0Hal and make it inherit from AllocatorHal. Do the same to Gralloc1Allocator. Add GrallocLoader to load either of Gralloc[01]Hal and create a IAllocator instance. Test: boots and VTS Change-Id: I09ae680c0086ca9e73e412a34d7cd2f3665d3bc2
2017-12-15 14:58:58 -08:00
"android.hardware.graphics.allocator@2.0-hal",
graphics: make mapper default impl a header library Reimplement the default impl as a header-only library, android.hardware.graphics.mapper@2.0-passthrough, based on the HAL support library. Effectively, this renames Gralloc[01]Mapper to Gralloc[01]Hal, and make adjustments here and there to meet the requirements of the HAL support library. This also adds GrallocLoader to load either of Gralloc[01]Hal and create an IMapper instance. libgrallocmapperincludes is renamed to follow the new naming and include path conventions. Test: boots and VTS Change-Id: I924cadce9a10a6e544f99ceba63aadc38ec431ac
2017-12-12 15:12:02 -08:00
"android.hardware.graphics.mapper@2.0-passthrough_headers",
graphics: make allocator default impl a static library Convert the default impl into a static library, android.hardware.graphics.allocator@2.0-passthrough. Test: boots and VTS Change-Id: I8ec8b30766462ecb3fb789af7c6dbb3c088ccf57
2017-12-15 14:41:42 -08:00
],
graphics: use allocator HAL support library in default impl Rename Gralloc0Allocator to Gralloc0Hal and make it inherit from AllocatorHal. Do the same to Gralloc1Allocator. Add GrallocLoader to load either of Gralloc[01]Hal and create a IAllocator instance. Test: boots and VTS Change-Id: I09ae680c0086ca9e73e412a34d7cd2f3665d3bc2
2017-12-15 14:58:58 -08:00
export_header_lib_headers: [
"android.hardware.graphics.allocator@2.0-hal",
graphics: make mapper default impl a header library Reimplement the default impl as a header-only library, android.hardware.graphics.mapper@2.0-passthrough, based on the HAL support library. Effectively, this renames Gralloc[01]Mapper to Gralloc[01]Hal, and make adjustments here and there to meet the requirements of the HAL support library. This also adds GrallocLoader to load either of Gralloc[01]Hal and create an IMapper instance. libgrallocmapperincludes is renamed to follow the new naming and include path conventions. Test: boots and VTS Change-Id: I924cadce9a10a6e544f99ceba63aadc38ec431ac
2017-12-12 15:12:02 -08:00
"android.hardware.graphics.mapper@2.0-passthrough_headers",
graphics: use allocator HAL support library in default impl Rename Gralloc0Allocator to Gralloc0Hal and make it inherit from AllocatorHal. Do the same to Gralloc1Allocator. Add GrallocLoader to load either of Gralloc[01]Hal and create a IAllocator instance. Test: boots and VTS Change-Id: I09ae680c0086ca9e73e412a34d7cd2f3665d3bc2
2017-12-15 14:58:58 -08:00
],
export_include_dirs: ["include"],
graphics: make allocator default impl a static library Convert the default impl into a static library, android.hardware.graphics.allocator@2.0-passthrough. Test: boots and VTS Change-Id: I8ec8b30766462ecb3fb789af7c6dbb3c088ccf57
2017-12-15 14:41:42 -08:00
}
Reference in New Issue Copy Permalink