From 0093415317a1bbae57c931a260f10d1580ad9794 Mon Sep 17 00:00:00 2001 From: Wyatt Riley Date: Thu, 19 Oct 2017 10:59:24 -0700 Subject: [PATCH] Clarifications to IGnss*.hal comments Clarified PRN vs. Satellite ID Corrected Measurement vs Clock typo Test: build check, including hash verification. Comments only. Change-Id: I1bef83800dbc796b1c8df43790f4239c81858d56 --- current.txt | 2 ++ gnss/1.0/IGnssCallback.hal | 6 +++--- gnss/1.0/IGnssMeasurementCallback.hal | 8 ++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/current.txt b/current.txt index 4a943b9a40..dc57c67f19 100644 --- a/current.txt +++ b/current.txt @@ -260,6 +260,8 @@ f4945e397b5dea41bb64518dfde59be71245d8a125fd1e0acffeb57ac7b08fed android.hardwar c8bc853546dd55584611def2a9fa1d99f657e3366c976d2f60fe6b8aa6d2cb87 android.hardware.thermal@1.1::IThermalCallback # ABI preserving changes to HALs during Android P +6fa9804a17a8bb7923a56bd10493a5483c20007e4c9026fd04287bee7c945a8c android.hardware.gnss@1.0::IGnssCallback fb92e2b40f8e9d494e8fd3b4ac18499a3216342e7cff160714c3bbf3660b6e79 android.hardware.gnss@1.0::IGnssConfiguration +251594ea9b27447bfa005ebd806e58fb0ae4aad84a69938129c9800ec0c64eda android.hardware.gnss@1.0::IGnssMeasurementCallback d4c10cb28318dba8efb22231a8c23e86ad8853f85775187c40b42a878a5ef4d5 android.hardware.automotive.vehicle@2.0::types cf72ff5a52bfa4d08e9e1000cf3ab5952a2d280c7f13cdad5ab7905c08050766 android.hardware.camera.metadata@3.2::types diff --git a/gnss/1.0/IGnssCallback.hal b/gnss/1.0/IGnssCallback.hal index 89e5e0e7f7..7fb38c5899 100644 --- a/gnss/1.0/IGnssCallback.hal +++ b/gnss/1.0/IGnssCallback.hal @@ -76,9 +76,9 @@ interface IGnssCallback { struct GnssSvInfo { /** - * Pseudo-random number for the SV, or FCN/OSN number for Glonass. The - * distinction is made by looking at constellation field. Values must be - * in the range of: + * Pseudo-random or satellite ID number for the satellite, a.k.a. Space Vehicle (SV), or + * FCN/OSN number for Glonass. The distinction is made by looking at constellation field. + * Values must be in the range of: * * - GNSS: 1-32 * - SBAS: 120-151, 183-192 diff --git a/gnss/1.0/IGnssMeasurementCallback.hal b/gnss/1.0/IGnssMeasurementCallback.hal index 403166477a..b27c2e0d35 100644 --- a/gnss/1.0/IGnssMeasurementCallback.hal +++ b/gnss/1.0/IGnssMeasurementCallback.hal @@ -496,7 +496,7 @@ interface IGnssMeasurementCallback { * to L1 must be filled, and in the other all of the values related to * L5 must be filled. * - * If the data is available, gnssClockFlags must contain + * If the data is available, gnssMeasurementFlags must contain * HAS_CARRIER_FREQUENCY. */ float carrierFrequencyHz; @@ -508,7 +508,7 @@ interface IGnssMeasurementCallback { * resets in the accumulation of this value can be inferred from the * accumulatedDeltaRangeState flags. * - * If the data is available, gnssClockFlags must contain + * If the data is available, gnssMeasurementFlags must contain * HAS_CARRIER_CYCLES. */ int64_t carrierCycles; @@ -521,14 +521,14 @@ interface IGnssMeasurementCallback { * The reference frequency is given by the field 'carrierFrequencyHz'. * The value contains the 'carrier-phase uncertainty' in it. * - * If the data is available, gnssClockFlags must contain + * If the data is available, gnssMeasurementFlags must contain * HAS_CARRIER_PHASE. */ double carrierPhase; /** * 1-Sigma uncertainty of the carrier-phase. - * If the data is available, gnssClockFlags must contain + * If the data is available, gnssMeasurementFlags must contain * HAS_CARRIER_PHASE_UNCERTAINTY. */ double carrierPhaseUncertainty;