From 0845d32131315b1a685f746ec972d1901e8856d4 Mon Sep 17 00:00:00 2001 From: Ruchi Kandoi Date: Wed, 6 Jun 2018 15:21:41 -0700 Subject: [PATCH] secure_element: vts: Fix openBasicChannel and transmit test case Status Response for basic channel can be only 2 bytes as well. Update the test to test for 2 or more bytes. Basic Channel if opened successfully should be closed. Transmit test case should specify the channel number in the command. Test: atest VtsHalSecureElementV1_0TargetTest Bug: 109833790 Change-Id: I91c943b4297067f6ae6872efb038f1295f92f5c8 Merged-In: I91c943b4297067f6ae6872efb038f1295f92f5c8 --- .../1.0/vts/functional/VtsHalSecureElementV1_0TargetTest.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/secure_element/1.0/vts/functional/VtsHalSecureElementV1_0TargetTest.cpp b/secure_element/1.0/vts/functional/VtsHalSecureElementV1_0TargetTest.cpp index dab81e2a23..3ea3e8dcac 100644 --- a/secure_element/1.0/vts/functional/VtsHalSecureElementV1_0TargetTest.cpp +++ b/secure_element/1.0/vts/functional/VtsHalSecureElementV1_0TargetTest.cpp @@ -134,6 +134,7 @@ TEST_F(SecureElementHidlTest, transmit) { EXPECT_LE((unsigned int)2, response.selectResponse.size()); EXPECT_LE(1, response.channelNumber); std::vector command = DATA_APDU; + command[0] |= response.channelNumber; std::vector transmitResponse; se_->transmit(command, [&transmitResponse](std::vector res) { transmitResponse.resize(res.size()); @@ -168,7 +169,8 @@ TEST_F(SecureElementHidlTest, openBasicChannel) { } }); if (statusReturned == SecureElementStatus::SUCCESS) { - EXPECT_LE((unsigned int)3, response.size()); + EXPECT_LE((unsigned int)2, response.size()); + se_->closeChannel(0); return; } EXPECT_EQ(SecureElementStatus::UNSUPPORTED_OPERATION, statusReturned);