From cfefc7b5e805caa9201d5fe9f91edbb75f0df866 Mon Sep 17 00:00:00 2001 From: Jintao Zhu Date: Sun, 14 Mar 2021 22:03:11 +0800 Subject: [PATCH] Fix RefBase Explicit destruction For an object to be managed by std smart pointer, its base class should NOT be "RefBase". It is not only unnecessary but also risking the object being owned by android smart pointer as well, which may destroy the object two times. This issue may be detected by the destructor of class RefBase, with the log complaint "RefBase: Explicit destruction,..." Test: monkey test for one day and one night Signed-off-by: Jintao Zhu Change-Id: If7736770983e17f5a4125b19dfbd1745ee5a9589 --- sensors/common/utils/EventMessageQueueWrapper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sensors/common/utils/EventMessageQueueWrapper.h b/sensors/common/utils/EventMessageQueueWrapper.h index c4f92c8386..63e4eb0704 100644 --- a/sensors/common/utils/EventMessageQueueWrapper.h +++ b/sensors/common/utils/EventMessageQueueWrapper.h @@ -33,7 +33,7 @@ namespace sensors { namespace V2_1 { namespace implementation { -class EventMessageQueueWrapperBase : public RefBase { +class EventMessageQueueWrapperBase { public: virtual ~EventMessageQueueWrapperBase() {}