From 0df10c4e41dd74f52ec0e17745ff6628d048e0fa Mon Sep 17 00:00:00 2001 From: Dan Stoza Date: Mon, 19 Dec 2016 15:22:47 -0800 Subject: [PATCH] HwcClient: Fix plane alpha Plane alpha was being sent as a float but read as unsigned, which, when converted to a float was causing things that were supposed to be translucent to be opaque. Bug: 33739111 Bug: 33737738 Test: Scrim behind modal dialogs is translucent and there is no more glitch when rotating apps Change-Id: I6896bdbb9928bd1aa7265b3ef25a7a96d54ee227 --- graphics/composer/2.1/default/HwcClient.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphics/composer/2.1/default/HwcClient.cpp b/graphics/composer/2.1/default/HwcClient.cpp index 16af94c1c4..5599959811 100644 --- a/graphics/composer/2.1/default/HwcClient.cpp +++ b/graphics/composer/2.1/default/HwcClient.cpp @@ -934,7 +934,7 @@ bool HwcClient::CommandReader::parseSetLayerPlaneAlpha(uint16_t length) return false; } - auto err = mHal.setLayerPlaneAlpha(mDisplay, mLayer, read()); + auto err = mHal.setLayerPlaneAlpha(mDisplay, mLayer, readFloat()); if (err != Error::NONE) { mWriter.setError(getCommandLoc(), err); }