From 44d525b68bb6e087d0fbe0b122c735a0fa9be8f7 Mon Sep 17 00:00:00 2001 From: Jim Kaye Date: Fri, 27 Sep 2019 12:21:36 -0700 Subject: [PATCH] Change AP_POWER_STATE_REPORT's access property. Change AP_POWER_STATE_REPORT's access property from WRITE to READ_WRITE. In Vehicle environment some hals communicate with external ecu, so they must know the boot reason. (Not only on, but DEEP_SLEEP_EXIT, ON, CANCELED) To handle this, AOSP provide CarPowerManager, but it use AIDL. But, in treble, vendor process must communicate with system process via hidl. So, vendor processes(almost hal), can't use CarPowerManager. (Beside, CarPowerManager use /dev/binder but vendor process use /dev/vndbinder). If hals subscribe AP_POWER_STATE_REPORT via vehicle hal, they can handle the power state. Bug: 140370318 Test: Verified on Hawk Change-Id: Ic4c7f1d66a4fdee1cfb8b9da42cf76bc7aed5948 --- automotive/vehicle/2.0/default/impl/vhal_v2_0/DefaultConfig.h | 2 +- automotive/vehicle/2.0/types.hal | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/automotive/vehicle/2.0/default/impl/vhal_v2_0/DefaultConfig.h b/automotive/vehicle/2.0/default/impl/vhal_v2_0/DefaultConfig.h index c8e11e3c30..094a37253e 100644 --- a/automotive/vehicle/2.0/default/impl/vhal_v2_0/DefaultConfig.h +++ b/automotive/vehicle/2.0/default/impl/vhal_v2_0/DefaultConfig.h @@ -786,7 +786,7 @@ const ConfigDeclaration kVehicleProperties[]{ .initialValue = {.int32Values = {toInt(VehicleApPowerStateReq::ON), 0}}}, {.config = {.prop = toInt(VehicleProperty::AP_POWER_STATE_REPORT), - .access = VehiclePropertyAccess::WRITE, + .access = VehiclePropertyAccess::READ_WRITE, .changeMode = VehiclePropertyChangeMode::ON_CHANGE}, .initialValue = {.int32Values = {toInt(VehicleApPowerStateReport::WAIT_FOR_VHAL), 0}}}, diff --git a/automotive/vehicle/2.0/types.hal b/automotive/vehicle/2.0/types.hal index 8c84c0a17e..9dfd558f79 100644 --- a/automotive/vehicle/2.0/types.hal +++ b/automotive/vehicle/2.0/types.hal @@ -1310,7 +1310,7 @@ enum VehicleProperty : int32_t { * * @change_mode VehiclePropertyChangeMode:ON_CHANGE - * @access VehiclePropertyAccess:WRITE + * @access VehiclePropertyAccess:READ_WRITE */ AP_POWER_STATE_REPORT = ( 0x0A01