diff --git a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp index ad8d4c877f..e0e3a0e9c4 100644 --- a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp +++ b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp @@ -288,77 +288,70 @@ TEST_P(CameraAidlTest, getCameraCharacteristics) { } TEST_P(CameraAidlTest, getSessionCharacteristics) { - if (flags::feature_combination_query()) { - std::vector cameraDeviceNames = getCameraDeviceNames(mProvider); + std::vector cameraDeviceNames = getCameraDeviceNames(mProvider); - for (const auto& name : cameraDeviceNames) { - std::shared_ptr device; - ALOGI("getSessionCharacteristics: Testing camera device %s", name.c_str()); - ndk::ScopedAStatus ret = mProvider->getCameraDeviceInterface(name, &device); - ALOGI("getCameraDeviceInterface returns: %d:%d", ret.getExceptionCode(), - ret.getServiceSpecificError()); - ASSERT_TRUE(ret.isOk()); - ASSERT_NE(device, nullptr); + for (const auto& name : cameraDeviceNames) { + std::shared_ptr device; + ALOGI("getSessionCharacteristics: Testing camera device %s", name.c_str()); + ndk::ScopedAStatus ret = mProvider->getCameraDeviceInterface(name, &device); + ALOGI("getCameraDeviceInterface returns: %d:%d", ret.getExceptionCode(), + ret.getServiceSpecificError()); + ASSERT_TRUE(ret.isOk()); + ASSERT_NE(device, nullptr); - int32_t interfaceVersion = -1; - ret = device->getInterfaceVersion(&interfaceVersion); - ASSERT_TRUE(ret.isOk()); - bool supportSessionCharacteristics = - (interfaceVersion >= CAMERA_DEVICE_API_MINOR_VERSION_3); - if (!supportSessionCharacteristics) { - continue; - } - - CameraMetadata meta; - openEmptyDeviceSession(name, mProvider, &mSession /*out*/, &meta /*out*/, - &device /*out*/); - - std::vector outputStreams; - camera_metadata_t* staticMeta = - reinterpret_cast(meta.metadata.data()); - outputStreams.clear(); - ASSERT_EQ(Status::OK, getAvailableOutputStreams(staticMeta, outputStreams)); - ASSERT_NE(0u, outputStreams.size()); - - AvailableStream sampleStream = outputStreams[0]; - - int32_t streamId = 0; - Stream stream = {streamId, - StreamType::OUTPUT, - sampleStream.width, - sampleStream.height, - static_cast(sampleStream.format), - static_cast( - GRALLOC1_CONSUMER_USAGE_VIDEO_ENCODER), - Dataspace::UNKNOWN, - StreamRotation::ROTATION_0, - std::string(), - /*bufferSize*/ 0, - /*groupId*/ -1, - {SensorPixelMode::ANDROID_SENSOR_PIXEL_MODE_DEFAULT}, - RequestAvailableDynamicRangeProfilesMap:: - ANDROID_REQUEST_AVAILABLE_DYNAMIC_RANGE_PROFILES_MAP_STANDARD}; - - std::vector streams = {stream}; - StreamConfiguration config; - createStreamConfiguration(streams, StreamConfigurationMode::NORMAL_MODE, &config); - - CameraMetadata camera_chars; - ret = device->getCameraCharacteristics(&camera_chars); - ASSERT_TRUE(ret.isOk()); - - CameraMetadata session_chars; - ret = device->getSessionCharacteristics(config, &session_chars); - ASSERT_TRUE(ret.isOk()); - verifySessionCharacteristics(session_chars, camera_chars); - - ret = mSession->close(); - mSession = nullptr; - ASSERT_TRUE(ret.isOk()); + int32_t interfaceVersion = -1; + ret = device->getInterfaceVersion(&interfaceVersion); + ASSERT_TRUE(ret.isOk()); + bool supportSessionCharacteristics = + (interfaceVersion >= CAMERA_DEVICE_API_MINOR_VERSION_3); + if (!supportSessionCharacteristics) { + continue; } - } else { - ALOGI("getSessionCharacteristics: Test skipped.\n"); - GTEST_SKIP(); + + CameraMetadata meta; + openEmptyDeviceSession(name, mProvider, &mSession /*out*/, &meta /*out*/, &device /*out*/); + + std::vector outputStreams; + camera_metadata_t* staticMeta = reinterpret_cast(meta.metadata.data()); + outputStreams.clear(); + ASSERT_EQ(Status::OK, getAvailableOutputStreams(staticMeta, outputStreams)); + ASSERT_NE(0u, outputStreams.size()); + + AvailableStream sampleStream = outputStreams[0]; + + int32_t streamId = 0; + Stream stream = {streamId, + StreamType::OUTPUT, + sampleStream.width, + sampleStream.height, + static_cast(sampleStream.format), + static_cast( + GRALLOC1_CONSUMER_USAGE_VIDEO_ENCODER), + Dataspace::UNKNOWN, + StreamRotation::ROTATION_0, + std::string(), + /*bufferSize*/ 0, + /*groupId*/ -1, + {SensorPixelMode::ANDROID_SENSOR_PIXEL_MODE_DEFAULT}, + RequestAvailableDynamicRangeProfilesMap:: + ANDROID_REQUEST_AVAILABLE_DYNAMIC_RANGE_PROFILES_MAP_STANDARD}; + + std::vector streams = {stream}; + StreamConfiguration config; + createStreamConfiguration(streams, StreamConfigurationMode::NORMAL_MODE, &config); + + CameraMetadata camera_chars; + ret = device->getCameraCharacteristics(&camera_chars); + ASSERT_TRUE(ret.isOk()); + + CameraMetadata session_chars; + ret = device->getSessionCharacteristics(config, &session_chars); + ASSERT_TRUE(ret.isOk()); + verifySessionCharacteristics(session_chars, camera_chars); + + ret = mSession->close(); + mSession = nullptr; + ASSERT_TRUE(ret.isOk()); } } @@ -615,19 +608,17 @@ TEST_P(CameraAidlTest, constructDefaultRequestSettings) { ASSERT_EQ(0u, rawMetadata.metadata.size()); } - if (flags::feature_combination_query()) { - if (supportFeatureCombinationQuery) { - CameraMetadata rawMetadata2; - ndk::ScopedAStatus ret2 = - device->constructDefaultRequestSettings(reqTemplate, &rawMetadata2); + if (supportFeatureCombinationQuery) { + CameraMetadata rawMetadata2; + ndk::ScopedAStatus ret2 = + device->constructDefaultRequestSettings(reqTemplate, &rawMetadata2); - ASSERT_EQ(ret.isOk(), ret2.isOk()); - ASSERT_EQ(ret.getStatus(), ret2.getStatus()); + ASSERT_EQ(ret.isOk(), ret2.isOk()); + ASSERT_EQ(ret.getStatus(), ret2.getStatus()); - ASSERT_EQ(rawMetadata.metadata.size(), rawMetadata2.metadata.size()); - if (ret2.isOk()) { - validateDefaultRequestMetadata(reqTemplate, rawMetadata2); - } + ASSERT_EQ(rawMetadata.metadata.size(), rawMetadata2.metadata.size()); + if (ret2.isOk()) { + validateDefaultRequestMetadata(reqTemplate, rawMetadata2); } } } diff --git a/camera/provider/aidl/vts/camera_aidl_test.cpp b/camera/provider/aidl/vts/camera_aidl_test.cpp index f905011806..6ecd45186c 100644 --- a/camera/provider/aidl/vts/camera_aidl_test.cpp +++ b/camera/provider/aidl/vts/camera_aidl_test.cpp @@ -1920,28 +1920,22 @@ void CameraAidlTest::verifyStreamCombination(const std::shared_ptrgetInterfaceVersion(&interfaceVersion); + int32_t interfaceVersion; + ret = device->getInterfaceVersion(&interfaceVersion); + ASSERT_TRUE(ret.isOk()); + bool supportFeatureCombinationQuery = + (interfaceVersion >= CAMERA_DEVICE_API_MINOR_VERSION_3); + if (supportFeatureCombinationQuery) { + ret = device->isStreamCombinationWithSettingsSupported(config, + &streamCombinationSupported); ASSERT_TRUE(ret.isOk()); - bool supportFeatureCombinationQuery = - (interfaceVersion >= CAMERA_DEVICE_API_MINOR_VERSION_3); - if (supportFeatureCombinationQuery) { - ret = device->isStreamCombinationWithSettingsSupported(config, - &streamCombinationSupported); - ASSERT_TRUE(ret.isOk()); - ASSERT_EQ(expectedStatus, streamCombinationSupported); - } + ASSERT_EQ(expectedStatus, streamCombinationSupported); } } } void CameraAidlTest::verifySessionCharacteristics(const CameraMetadata& session_chars, const CameraMetadata& camera_chars) { - if (!flags::feature_combination_query()) { - return; - } - const camera_metadata_t* session_metadata = reinterpret_cast(session_chars.metadata.data());