From 978a0f9ea0733227ca9a2ed3b66270424a19f5a8 Mon Sep 17 00:00:00 2001 From: Mikhail Naganov Date: Fri, 5 Aug 2022 00:24:27 +0000 Subject: [PATCH] audio: Restrict the new VTS test for effects to T+ The VTS test AudioEffectHidlTest#GetParameterInvalidMaxReplySize should only run for new devices launching on T+ because older vendor images do not have updated HAL default wrapper code and thus will fail. Bug: 237291425 Bug: 240932876 Test: atest VtsHalAudioEffectV7_0TargetTest:Equalizer_IEffect/AudioEffectHidlTest#GetParameterInvalidMaxReplySize/0_default Change-Id: I1697155fe7781cbc96c1913e674699e299aa26b3 --- .../vts/functional/VtsHalAudioEffectTargetTest.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/audio/effect/all-versions/vts/functional/VtsHalAudioEffectTargetTest.cpp b/audio/effect/all-versions/vts/functional/VtsHalAudioEffectTargetTest.cpp index ffa4c56e7a..c808ff6cc2 100644 --- a/audio/effect/all-versions/vts/functional/VtsHalAudioEffectTargetTest.cpp +++ b/audio/effect/all-versions/vts/functional/VtsHalAudioEffectTargetTest.cpp @@ -35,6 +35,7 @@ #include +#include #include #include #include @@ -625,6 +626,10 @@ TEST_P(AudioEffectHidlTest, GetParameter) { TEST_P(AudioEffectHidlTest, GetParameterInvalidMaxReplySize) { description("Verify that GetParameter caps the maximum reply size"); + const bool isNewDeviceLaunchingOnTPlus = property_get_int32("ro.vendor.api_level", 0) >= 33; + if (!isNewDeviceLaunchingOnTPlus) { + GTEST_SKIP() << "The test only applies to devices launching on T or later"; + } // Use a non-empty parameter to avoid being rejected by any earlier checks. hidl_vec parameter; parameter.resize(16);