From a0234940b3b2caa8b624a065512184532f002cb1 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Tue, 7 Nov 2023 13:10:43 -0800 Subject: [PATCH] audio: VtsHalAudioCoreModuleTargetTest: Convert a SIGSEGV into an assertion failure Convert the following segmentation fault into an assertion failure: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000 Cause: null pointer dereference 9 total frames backtrace: #00 pc 000000000020e532 /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (AudioCoreModuleBase::TearDownImpl()+114) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #01 pc 00000000001c890a /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (AudioCoreModule::TearDown()+106) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #02 pc 00000000002b62a8 /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (testing::TestInfo::Run()+424) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #03 pc 00000000002b6de4 /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (testing::TestSuite::Run()+804) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #04 pc 00000000002c5c7e /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (testing::internal::UnitTestImpl::RunAllTests()+2622) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #05 pc 00000000002c50cc /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (testing::UnitTest::Run()+140) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #06 pc 00000000001c86f0 /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (RUN_ALL_TESTS()+16) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #07 pc 00000000001c8669 /data/local/tmp/VtsHalAudioCoreTargetTest/x86_64/VtsHalAudioCoreTargetTest (main+137) (BuildId: f1bb3c414cf012ccd7d268b4e0c7fefe) #08 pc 00000000000547e9 /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+89) (BuildId: e5ef3cc48c1e014ffb7dbbcfc7f9d475) Bug: 308687042 Change-Id: I2d528dd9cf0f59bcd6b0e485b4f6141320d89a81 Signed-off-by: Bart Van Assche --- audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp b/audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp index 536bc26481..697aae9a30 100644 --- a/audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp +++ b/audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp @@ -446,6 +446,7 @@ class AudioCoreModuleBase { void TearDownImpl() { debug.reset(); + ASSERT_NE(module, nullptr); std::vector finalPorts; ASSERT_IS_OK(module->getAudioPorts(&finalPorts)); EXPECT_NO_FATAL_FAILURE(VerifyVectorsAreEqual(initialPorts, finalPorts))