From 1b7c33562f34bcfe6cfb098f8a8ad868c9984449 Mon Sep 17 00:00:00 2001 From: Tri Vo Date: Fri, 4 Aug 2017 17:05:51 -0700 Subject: [PATCH] Graphics tests statically link to HAL definition libs. These tests now statically links to HAL def libs which are not guaranteed to be on the device. Bug: 64040096 Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check --skip-preconditions --module VtsHalGraphicsMapperV2_0Target Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check --skip-preconditions --module VtsHalGraphicsComposerV2_1Target Change-Id: I83b68dafbd161f88394f67dbda14f9957ddf7232 --- .../composer/2.1/vts/functional/Android.bp | 30 ++++++------------- graphics/mapper/2.0/vts/functional/Android.bp | 22 +++----------- 2 files changed, 13 insertions(+), 39 deletions(-) diff --git a/graphics/composer/2.1/vts/functional/Android.bp b/graphics/composer/2.1/vts/functional/Android.bp index 2e87144dbb..1ba7c9a1b2 100644 --- a/graphics/composer/2.1/vts/functional/Android.bp +++ b/graphics/composer/2.1/vts/functional/Android.bp @@ -44,33 +44,21 @@ cc_library_static { cc_test { name: "VtsHalGraphicsComposerV2_1TargetTest", - defaults: ["hidl_defaults"], + defaults: ["VtsHalTargetTestDefaults"], srcs: ["VtsHalGraphicsComposerV2_1TargetTest.cpp"], + + // TODO(b/64437680): Assume these libs are always available on the device. shared_libs: [ + "libfmq", + "libsync", + ], + static_libs: [ "android.hardware.graphics.allocator@2.0", "android.hardware.graphics.composer@2.1", "android.hardware.graphics.mapper@2.0", - "libbase", - "libcutils", - "libfmq", - "libhidlbase", - "libhidltransport", - "liblog", - "libnativehelper", - "libsync", - "libutils", - ], - static_libs: [ - "libhwcomposer-command-buffer", "libVtsHalGraphicsComposerTestUtils", "libVtsHalGraphicsMapperTestUtils", - "VtsHalHidlTargetTestBase", + "libhwcomposer-command-buffer", + "libnativehelper", ], - cflags: [ - "-Wall", - "-Wextra", - "-Werror", - "-O0", - "-g", - ] } diff --git a/graphics/mapper/2.0/vts/functional/Android.bp b/graphics/mapper/2.0/vts/functional/Android.bp index 1c0e4c5a32..ac6cb47a68 100644 --- a/graphics/mapper/2.0/vts/functional/Android.bp +++ b/graphics/mapper/2.0/vts/functional/Android.bp @@ -37,30 +37,16 @@ cc_library_static { cc_test { name: "VtsHalGraphicsMapperV2_0TargetTest", - defaults: ["hidl_defaults"], + defaults: ["VtsHalTargetTestDefaults"], srcs: ["VtsHalGraphicsMapperV2_0TargetTest.cpp"], shared_libs: [ - "libbase", - "liblog", - "libcutils", - "libhidlbase", - "libhidltransport", - "libnativehelper", "libsync", - "libutils", + ], + static_libs: [ "android.hardware.graphics.allocator@2.0", "android.hardware.graphics.mapper@2.0", "android.hardware.graphics.common@1.0", - ], - static_libs: [ "libVtsHalGraphicsMapperTestUtils", - "VtsHalHidlTargetTestBase", + "libnativehelper", ], - cflags: [ - "-Wall", - "-Wextra", - "-Werror", - "-O0", - "-g", - ] }