From 1fb9ba494c43ee7c2fd4d09a3513f0f98ed5c01f Mon Sep 17 00:00:00 2001 From: Avichal Rakesh Date: Wed, 13 Dec 2023 13:09:57 -0800 Subject: [PATCH] ExternalCameraHAL: Add ANDROID_SENSOR_READOUT_TIMESTAMP key. As ExternalCameraHAL does not support sensor readout timestamp, it should set ANDROID_SENSOR_READOUT_TIMESTAMP to ANDROID_SENSOR_READOUT_TIMESTAMP_NOT_SUPPORTED in CameraDevice characteristics. This CL adds the CameraMetadata entry to ExternalCameraDevice. Bug: 309543399 Test: ReadoutTimestampTest#testReadoutTimestamp passes for ExternalCameraHAL Change-Id: I12203f0832416b4ca325380e671675ddc1d788d4 --- camera/device/default/ExternalCameraDevice.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/camera/device/default/ExternalCameraDevice.cpp b/camera/device/default/ExternalCameraDevice.cpp index 649bf43f49..8e8474800f 100644 --- a/camera/device/default/ExternalCameraDevice.cpp +++ b/camera/device/default/ExternalCameraDevice.cpp @@ -497,6 +497,9 @@ status_t ExternalCameraDevice::initDefaultCharsKeys( const int32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN; UPDATE(ANDROID_SYNC_MAX_LATENCY, &maxLatency, 1); + const uint8_t sensorReadoutTimestamp = ANDROID_SENSOR_READOUT_TIMESTAMP_NOT_SUPPORTED; + UPDATE(ANDROID_SENSOR_READOUT_TIMESTAMP, &sensorReadoutTimestamp, 1); + /* Other sensor/RAW related keys: * android.sensor.info.colorFilterArrangement -> no need if we don't do RAW * android.sensor.info.physicalSize -> not available @@ -1002,4 +1005,4 @@ binder_status_t ExternalCameraDevice::dump(int fd, const char** args, uint32_t n } // namespace device } // namespace camera } // namespace hardware -} // namespace android \ No newline at end of file +} // namespace android