From 17927df5ef85be1989823db85b48c100ef594159 Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Thu, 9 Feb 2023 17:46:52 +0000 Subject: [PATCH] Effect AIDL: Fix a couple logging statements Since the ternary conditional has lower precedence than "<<", we need to add parentheses. Bug: 264618800 Change-Id: Idc10c0d231057a74e41d0a10bf20e1e28c1ce84e Test: TreeHugger --- audio/aidl/default/EffectThread.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/aidl/default/EffectThread.cpp b/audio/aidl/default/EffectThread.cpp index f7894c457a..024c0eaeed 100644 --- a/audio/aidl/default/EffectThread.cpp +++ b/audio/aidl/default/EffectThread.cpp @@ -86,14 +86,14 @@ RetCode EffectThread::handleStartStop(bool stop) { { std::lock_guard lg(mThreadMutex); if (stop == mStop) { - LOG(WARNING) << __func__ << " already " << stop ? "stop" : "start"; + LOG(WARNING) << __func__ << " already " << (stop ? "stop" : "start"); return RetCode::SUCCESS; } mStop = stop; } mCv.notify_one(); - LOG(DEBUG) << stop ? "stop done" : "start done"; + LOG(DEBUG) << (stop ? "stop done" : "start done"); return RetCode::SUCCESS; }