From e1723a49dfe3c6499eb8983cccd9713033980e73 Mon Sep 17 00:00:00 2001 From: "Harpreet \\\"Eli\\\" Sangha" Date: Fri, 6 Dec 2019 14:09:33 +0900 Subject: [PATCH] vibrator: vts: Utilize New toString() Support Use the new toString() support for AIDL enums for improved logging. Test: atest VtsHalVibratorTargetTest Change-Id: Ie9d98f6b9f367dec9e6f0b9b0ed18dab0a32c742 Signed-off-by: Harpreet \"Eli\" Sangha --- vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp b/vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp index 5c6120b6f5..6f9ba1a96e 100644 --- a/vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp +++ b/vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp @@ -135,13 +135,12 @@ TEST_P(VibratorAidl, ValidateEffect) { Status status = vibrator->perform(effect, strength, nullptr /*callback*/, &lengthMs); if (isEffectSupported) { - EXPECT_TRUE(status.isOk()) - << static_cast(effect) << " " << static_cast(strength); + EXPECT_TRUE(status.isOk()) << toString(effect) << " " << toString(strength); EXPECT_GT(lengthMs, 0); usleep(lengthMs * 1000); } else { EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION) - << static_cast(effect) << " " << static_cast(strength); + << toString(effect) << " " << toString(strength); EXPECT_EQ(lengthMs, 0); } } @@ -202,7 +201,7 @@ TEST_P(VibratorAidl, InvalidEffectsUnsupported) { int32_t lengthMs; Status status = vibrator->perform(effect, strength, nullptr /*callback*/, &lengthMs); EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION) - << static_cast(effect) << " " << static_cast(strength); + << toString(effect) << " " << toString(strength); } } for (Effect effect : kEffects) { @@ -210,7 +209,7 @@ TEST_P(VibratorAidl, InvalidEffectsUnsupported) { int32_t lengthMs; Status status = vibrator->perform(effect, strength, nullptr /*callback*/, &lengthMs); EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION) - << static_cast(effect) << " " << static_cast(strength); + << toString(effect) << " " << toString(strength); } } }