From 7d601ebfb6ec18726abef923b27310669768a18d Mon Sep 17 00:00:00 2001 From: Austin Borger Date: Mon, 3 Apr 2023 11:07:24 -0700 Subject: [PATCH] Camera: Update documentation for dataSpace/colorSpace in Stream.aidl. Bug: 271350569 Test: N/A Change-Id: I3f853cece53d102c231a8de1cfcab5ed1fdb0dc0 --- .../android/hardware/camera/device/Stream.aidl | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/camera/device/aidl/android/hardware/camera/device/Stream.aidl b/camera/device/aidl/android/hardware/camera/device/Stream.aidl index 457b1bc768..0a657d70d7 100644 --- a/camera/device/aidl/android/hardware/camera/device/Stream.aidl +++ b/camera/device/aidl/android/hardware/camera/device/Stream.aidl @@ -107,9 +107,10 @@ parcelable Stream { * supported. The dataspace values are set using the V0 dataspace * definitions. * - * The color space implied by dataSpace should be overridden by colorSpace if - * the device supports the REQUEST_AVAILABLE_CAPABILITIES_COLOR_SPACE_PROFILES - * capability. + * The standard bits of this field will match the requested colorSpace (if set) for + * non-BLOB formats. For BLOB formats, if colorSpace is not + * ANDROID_REQUEST_AVAILABLE_COLOR_SPACE_PROFILES_MAP_UNSPECIFIED, colorSpace takes + * over as the authority for the color space of the stream regardless of dataSpace. */ android.hardware.graphics.common.Dataspace dataSpace; @@ -234,11 +235,11 @@ parcelable Stream { * ANDROID_REQUEST_AVAILABLE_COLOR_SPACE_PROFILES_MAP_UNSPECIFIED, and the color space * implied by dataSpace should be used instead. * - * When specified, this field is the ultimate authority over the color space of the stream, - * regardless of dataSpace. The purpose of this field is to support specifying wide gamut - * color spaces for dataSpace values such as JFIF and HEIF. + * When specified, this field and the standard bits of dataSpace will match for non-BLOB + * formats. For BLOB formats, the dataSpace will remain unchanged. In this case, this field is + * the ultimate authority over the color space of the stream. * - * Possible values are the ordinals of the ColorSpace.Named enum in the public-facing API. + * See ANDROID_REQUEST_AVAILABLE_COLOR_SPACE_PROFILES_MAP for possible values. */ int colorSpace; }