From 849e9fc8b673920a478fb68ad9d6c71251d4510c Mon Sep 17 00:00:00 2001 From: Suren Baghdasaryan Date: Thu, 30 Apr 2020 13:40:40 -0700 Subject: [PATCH] Replace direct pid writes with setting task profiles for camera interfaces For easy transition from SchedTune to UtilClamp, direct access to these cgroups should be abstracted by using task profiles. Replace writepid commands with new task_profiles command. Bug: 155419956 Test: change .rc file and confirm task profile is applied Signed-off-by: Suren Baghdasaryan Change-Id: I2732f7365351f132dbf0566319e3969c2a25b3e4 --- .../android.hardware.camera.provider@2.4-external-service.rc | 2 +- .../android.hardware.camera.provider@2.4-service-lazy.rc | 2 +- .../android.hardware.camera.provider@2.4-service-lazy_64.rc | 2 +- .../2.4/default/android.hardware.camera.provider@2.4-service.rc | 2 +- .../default/android.hardware.camera.provider@2.4-service_64.rc | 2 +- .../android.hardware.camera.provider@2.5-external-service.rc | 2 +- .../android.hardware.camera.provider@2.5-service-lazy.rc | 2 +- .../android.hardware.camera.provider@2.5-service-lazy_64.rc | 2 +- .../2.5/default/android.hardware.camera.provider@2.5-service.rc | 2 +- .../default/android.hardware.camera.provider@2.5-service_64.rc | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-external-service.rc b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-external-service.rc index 64cf321d83..52ade977b3 100644 --- a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-external-service.rc +++ b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-external-service.rc @@ -5,4 +5,4 @@ service vendor.camera-provider-2-4-ext /vendor/bin/hw/android.hardware.camera.pr group audio camera input drmrpc usb ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy.rc b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy.rc index e8549ed82d..63ded900c0 100644 --- a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy.rc +++ b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy.rc @@ -7,4 +7,4 @@ service vendor.camera-provider-2-4 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy_64.rc b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy_64.rc index 2dfac764eb..953d1af7e4 100644 --- a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy_64.rc +++ b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service-lazy_64.rc @@ -7,4 +7,4 @@ service vendor.camera-provider-2-4 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service.rc b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service.rc index 913561b1fe..f7ac9f83e4 100644 --- a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service.rc +++ b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service.rc @@ -5,4 +5,4 @@ service vendor.camera-provider-2-4 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service_64.rc b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service_64.rc index fd4826ec2c..a32dd468d3 100644 --- a/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service_64.rc +++ b/camera/provider/2.4/default/android.hardware.camera.provider@2.4-service_64.rc @@ -5,4 +5,4 @@ service vendor.camera-provider-2-4 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-external-service.rc b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-external-service.rc index 107097e661..b3b06b2391 100644 --- a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-external-service.rc +++ b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-external-service.rc @@ -6,4 +6,4 @@ service vendor.camera-provider-2-5-ext /vendor/bin/hw/android.hardware.camera.pr group audio camera input drmrpc usb ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy.rc b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy.rc index b45158a082..7c5e69b070 100644 --- a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy.rc +++ b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy.rc @@ -8,4 +8,4 @@ service vendor.camera-provider-2-5 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy_64.rc b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy_64.rc index 955b28e6b4..49bca8f93c 100644 --- a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy_64.rc +++ b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service-lazy_64.rc @@ -8,4 +8,4 @@ service vendor.camera-provider-2-5 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service.rc b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service.rc index c065815fab..4bd1fb4078 100644 --- a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service.rc +++ b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service.rc @@ -6,4 +6,4 @@ service vendor.camera-provider-2-5 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance diff --git a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service_64.rc b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service_64.rc index 63dd11d349..b4443256cf 100644 --- a/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service_64.rc +++ b/camera/provider/2.5/default/android.hardware.camera.provider@2.5-service_64.rc @@ -6,4 +6,4 @@ service vendor.camera-provider-2-5 /vendor/bin/hw/android.hardware.camera.provid group audio camera input drmrpc ioprio rt 4 capabilities SYS_NICE - writepid /dev/cpuset/camera-daemon/tasks /dev/stune/top-app/tasks + task_profiles CameraServiceCapacity MaxPerformance