diff --git a/secure_element/aidl/default/main.cpp b/secure_element/aidl/default/main.cpp index 6149eae387..0822402a87 100644 --- a/secure_element/aidl/default/main.cpp +++ b/secure_element/aidl/default/main.cpp @@ -586,7 +586,7 @@ class EmulatedSecureElement : public BnSecureElement { // The selected basic or logical channel is not opened. if (channel_number >= channels_.size() || !channels_[channel_number].opened) { - return ScopedAStatus::ok(); + return ScopedAStatus::fromServiceSpecificError(FAILED); } // TODO(b/123254068) - this is not an implementation of the OMAPI protocol diff --git a/secure_element/aidl/vts/VtsHalSecureElementTargetTest.cpp b/secure_element/aidl/vts/VtsHalSecureElementTargetTest.cpp index c2655793ba..37ff1b207a 100644 --- a/secure_element/aidl/vts/VtsHalSecureElementTargetTest.cpp +++ b/secure_element/aidl/vts/VtsHalSecureElementTargetTest.cpp @@ -109,6 +109,7 @@ class SecureElementAidl : public ::testing::TestWithParam { } void TearDown() override { + EXPECT_OK(secure_element_->reset()); secure_element_ = nullptr; secure_element_callback_ = nullptr; } @@ -232,10 +233,10 @@ TEST_P(SecureElementAidl, closeChannel) { std::vector basic_channel_response; LogicalChannelResponse logical_channel_response; - // closeChannel called on non-existing basic or logical channel is a no-op - // and shall succeed. - EXPECT_OK(secure_element_->closeChannel(0)); - EXPECT_OK(secure_element_->closeChannel(1)); + // closeChannel called on non-existing basic or logical channel + // shall fail. + EXPECT_ERR(secure_element_->closeChannel(0)); + EXPECT_ERR(secure_element_->closeChannel(1)); // closeChannel called on basic channel closes the basic channel. EXPECT_OK(secure_element_->openBasicChannel(kSelectableAid, 0x00, &basic_channel_response));