Return empty suffix for invalid slots am: a6759d5d66 am: 2dba4ac8b4

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2166409

Change-Id: Id5a45519a52e90cf9ff936ba50c1678dcb93cd2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Kelvin Zhang
2022-07-29 00:03:52 +00:00
committed by Automerger Merge Worker

View File

@@ -84,10 +84,12 @@ ScopedAStatus BootControl::getSnapshotMergeStatus(MergeStatus* _aidl_return) {
ScopedAStatus BootControl::getSuffix(int32_t in_slot, std::string* _aidl_return) {
if (!impl_.IsValidSlot(in_slot)) {
return ScopedAStatus::fromServiceSpecificErrorWithMessage(
INVALID_SLOT, (std::string("Invalid slot ") + std::to_string(in_slot)).c_str());
// Old HIDL hal returns empty string for invalid slots. We should maintain this behavior in
// AIDL for compatibility.
_aidl_return->clear();
} else {
*_aidl_return = impl_.GetSuffix(in_slot);
}
*_aidl_return = impl_.GetSuffix(in_slot);
return ScopedAStatus::ok();
}