diff --git a/security/keymint/aidl/android/hardware/security/keymint/IKeyMintDevice.aidl b/security/keymint/aidl/android/hardware/security/keymint/IKeyMintDevice.aidl index 5b0b303cc0..88b2a265dc 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/IKeyMintDevice.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/IKeyMintDevice.aidl @@ -233,8 +233,6 @@ interface IKeyMintDevice { * indistinguishable from random. Thus, if the entropy from any source is good, the output * must be good. * - * TODO(seleneh) specify what mixing functions and cprng we allow. - * * @param data Bytes to be mixed into the CRNG seed. The caller must not provide more than 2 * KiB of data per invocation. * diff --git a/security/keymint/aidl/android/hardware/security/keymint/KeyMintHardwareInfo.aidl b/security/keymint/aidl/android/hardware/security/keymint/KeyMintHardwareInfo.aidl index 8da75784de..b82dee626b 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/KeyMintHardwareInfo.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/KeyMintHardwareInfo.aidl @@ -29,7 +29,6 @@ parcelable KeyMintHardwareInfo { * Implementation version of the keymint hardware. The version number is implementation * defined, and not necessarily globally meaningful. The version is used to distinguish * between different versions of a given implementation. - * TODO(seleneh) add the version related info to the code. */ int versionNumber; diff --git a/security/keymint/aidl/android/hardware/security/keymint/PaddingMode.aidl b/security/keymint/aidl/android/hardware/security/keymint/PaddingMode.aidl index fbb373b873..e71a9c92cb 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/PaddingMode.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/PaddingMode.aidl @@ -17,8 +17,6 @@ package android.hardware.security.keymint; /** - * TODO(seleneh) update the description. - * * Padding modes that may be applied to plaintext for encryption operations. This list includes * padding modes for both symmetric and asymmetric algorithms. Note that implementations should not * provide all possible combinations of algorithm and padding, only the diff --git a/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl b/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl index 861084eb23..972ce2e5c7 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl @@ -268,10 +268,6 @@ enum Tag { USAGE_EXPIRE_DATETIME = TagType.DATE | 402, /** - * TODO(seleneh) this tag need to be deleted. - * - * TODO(seleneh) this tag need to be deleted. - * * Tag::MIN_SECONDS_BETWEEN_OPS specifies the minimum amount of time that elapses between * allowed operations using a key. This can be used to rate-limit uses of keys in contexts * where unlimited use may enable brute force attacks. @@ -289,6 +285,8 @@ enum Tag { * fails because the table is full, KeyMint returns ErrorCode::TOO_MANY_OPERATIONS. * * Must be hardware-enforced. + * + * TODO(b/191458710): find out if this tag is still supported. */ MIN_SECONDS_BETWEEN_OPS = TagType.UINT | 403, @@ -876,6 +874,7 @@ enum Tag { STORAGE_KEY = TagType.BOOL | 722, /** + * OBSOLETE: Do not use. See IKeyMintOperation.updateAad instead. * TODO: Delete when keystore1 is deleted. */ ASSOCIATED_DATA = TagType.BYTES | 1000,