From 2ea148804abbdbe4d3479413779484af86020a05 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Fri, 1 Nov 2019 13:31:25 -0700 Subject: [PATCH] camera: fix two potential null pointer uses Caught by the static analyzer: hardware/interfaces/camera/device/1.0/default/CameraDevice.cpp:401:9: warning: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage] Bug: None Test: TreeHugger Change-Id: Ia6d0a2ab4b4d04cfc171629c7dbf60ead181625d --- camera/device/1.0/default/CameraDevice.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/camera/device/1.0/default/CameraDevice.cpp b/camera/device/1.0/default/CameraDevice.cpp index a03bbc8670..2dd6094a53 100644 --- a/camera/device/1.0/default/CameraDevice.cpp +++ b/camera/device/1.0/default/CameraDevice.cpp @@ -397,9 +397,11 @@ void CameraDevice::sPutMemory(camera_memory_t *data) { CameraDevice* device = mem->handle.mDevice; if (device == nullptr) { ALOGE("%s: camera HAL return memory for a null device!", __FUNCTION__); + return; } if (device->mDeviceCallback == nullptr) { ALOGE("%s: camera HAL return memory while camera is not opened!", __FUNCTION__); + return; } device->mDeviceCallback->unregisterMemory(mem->handle.mId); {