From 7c046786b865d3131377ab015acbc15529cf8ba8 Mon Sep 17 00:00:00 2001 From: Eran Messeri Date: Mon, 28 Jun 2021 12:07:37 +0100 Subject: [PATCH] Annotate some TODOs There are two tags that cannot be currently removed but should be removed in KeyMint V2. Mark them as deprecated and point to the bug for deletion. Bug: 183737811 Test: That it compiles. Change-Id: I80ccaedeb777fdb249a8cb021db6628da32d6029 --- .../keymint/aidl/android/hardware/security/keymint/Tag.aidl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl b/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl index e8ff14f3c6..ec5f3d3ee7 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/Tag.aidl @@ -286,7 +286,7 @@ enum Tag { * * Must be hardware-enforced. * - * TODO(b/191458710): find out if this tag is still supported. + * TODO(b/191738660): Remove in KeyMint V2. Currently only used for FDE. */ MIN_SECONDS_BETWEEN_OPS = TagType.UINT | 403, @@ -878,7 +878,7 @@ enum Tag { /** * OBSOLETE: Do not use. See IKeyMintOperation.updateAad instead. - * TODO: Delete when keystore1 is deleted. + * TODO(b/191738660): Remove in KeyMint v2. */ ASSOCIATED_DATA = TagType.BYTES | 1000,