From 2a84d48e5a5618f8f3b792546d422da6f6216755 Mon Sep 17 00:00:00 2001 From: Courtney Goeltzenleuchter Date: Thu, 5 Jan 2017 15:59:20 -0700 Subject: [PATCH 1/2] Remove TODO Test: Visually inspect file. Bug: 34109639 Change-Id: If443b4beb1ff06429a8e3ee564a0892d6acd0e9d --- graphics/common/1.0/types.hal | 4 ---- 1 file changed, 4 deletions(-) diff --git a/graphics/common/1.0/types.hal b/graphics/common/1.0/types.hal index e20fedc5b3..e65b6ac4ab 100644 --- a/graphics/common/1.0/types.hal +++ b/graphics/common/1.0/types.hal @@ -928,10 +928,6 @@ enum Dataspace : int32_t { * A pixel value of 1.0, 1.0, 1.0 corresponds to sRGB white (D65) at 80 nits. * Values beyond the range [0.0 - 1.0] would correspond to other colors * spaces and/or HDR content. - * - * TODO (courtneygo): Will we actually use this? We intend to use FP16 - * storage for data using scRGB so we can do all work in linear space - * and don't have to worry as much about limited precision. */ V0_SCRGB = STANDARD_BT709 | TRANSFER_SRGB | RANGE_EXTENDED, From 5f3da62cd892438911da48bf6951842d2ad041c0 Mon Sep 17 00:00:00 2001 From: Courtney Goeltzenleuchter Date: Thu, 5 Jan 2017 16:11:57 -0700 Subject: [PATCH 2/2] Add Display P3 DATASPACE enums Need to define Display-P3 dataspace. Test: grep HAL_DATASPACE_DISPLAY_P3 system/core/include/system/graphics-base.h Change-Id: I0a2015eb714f9e6f8c2e8cff40b008e58570ba55 --- graphics/common/1.0/types.hal | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/graphics/common/1.0/types.hal b/graphics/common/1.0/types.hal index e65b6ac4ab..ebdba7782e 100644 --- a/graphics/common/1.0/types.hal +++ b/graphics/common/1.0/types.hal @@ -1010,6 +1010,24 @@ enum Dataspace : int32_t { DCI_P3 = STANDARD_DCI_P3 | TRANSFER_GAMMA2_6 | RANGE_FULL, + /* + * Display P3 + * + * Display P3 uses same primaries and white-point as DCI-P3 + * linear transfer function makes this the same as DCI_P3_LINEAR. + */ + DISPLAY_P3_LINEAR = STANDARD_DCI_P3 | TRANSFER_LINEAR | RANGE_FULL, + + + /* + * Display P3 + * + * Use same primaries and white-point as DCI-P3 + * but sRGB transfer function. + */ + DISPLAY_P3 = STANDARD_DCI_P3 | TRANSFER_SRGB | RANGE_FULL, + + /* * Adobe RGB *