From 3e76e28a9421a82d481d08d0686656fc378db03e Mon Sep 17 00:00:00 2001 From: Tomasz Wasilczyk Date: Mon, 4 Nov 2024 07:31:45 -0800 Subject: [PATCH] Refine Radio HAL comments. - Add potential error codes to some responses. - Relax iccTransmitApduBasicChannel requirements on HAL. - Add reference to LTE bandwidth validity spec. Bug: 310710841 Test: N/A Flag: EXEMPT no logic change Change-Id: I446714b0f89df68377e4a5618b7c4dca59e89610 --- radio/aidl/android/hardware/radio/network/CellIdentityLte.aidl | 2 +- radio/aidl/android/hardware/radio/sim/IRadioSim.aidl | 2 +- radio/aidl/android/hardware/radio/sim/IRadioSimResponse.aidl | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/radio/aidl/android/hardware/radio/network/CellIdentityLte.aidl b/radio/aidl/android/hardware/radio/network/CellIdentityLte.aidl index 27c25809b5..c4c76cfd91 100644 --- a/radio/aidl/android/hardware/radio/network/CellIdentityLte.aidl +++ b/radio/aidl/android/hardware/radio/network/CellIdentityLte.aidl @@ -53,7 +53,7 @@ parcelable CellIdentityLte { */ OperatorInfo operatorNames; /** - * Cell bandwidth, in kHz. + * Cell bandwidth, in kHz. Must be valid as described in TS 36.101 5.6. */ int bandwidth; /** diff --git a/radio/aidl/android/hardware/radio/sim/IRadioSim.aidl b/radio/aidl/android/hardware/radio/sim/IRadioSim.aidl index 7870a749b0..1e010b90be 100644 --- a/radio/aidl/android/hardware/radio/sim/IRadioSim.aidl +++ b/radio/aidl/android/hardware/radio/sim/IRadioSim.aidl @@ -257,7 +257,7 @@ oneway interface IRadioSim { * Request APDU exchange on the basic channel. This command reflects TS 27.007 * "generic SIM access" operation (+CSIM). The modem must ensure proper function of GSM/CDMA, * and filter commands appropriately. It must filter channel management and SELECT by DF - * name commands. "sessionid" field must be ignored. + * name commands. "sessionId" field is always 0 (for aid="") and may be ignored. * * @param serial Serial number of request. * @param message SimApdu to be sent diff --git a/radio/aidl/android/hardware/radio/sim/IRadioSimResponse.aidl b/radio/aidl/android/hardware/radio/sim/IRadioSimResponse.aidl index 91b57292be..cf08bada7f 100644 --- a/radio/aidl/android/hardware/radio/sim/IRadioSimResponse.aidl +++ b/radio/aidl/android/hardware/radio/sim/IRadioSimResponse.aidl @@ -263,6 +263,8 @@ oneway interface IRadioSimResponse { * RadioError:NONE * RadioError:RADIO_NOT_AVAILABLE * RadioError:INTERNAL_ERR + * RadioError:INVALID_ARGUMENTS when given channel is invalid or basic (channel 0) + * RadioError:MISSING_RESOURCE when given channel is not open * RadioError:NO_MEMORY * RadioError:NO_RESOURCES * RadioError:CANCELLED @@ -325,6 +327,7 @@ oneway interface IRadioSimResponse { * RadioError:NONE * RadioError:RADIO_NOT_AVAILABLE * RadioError:INTERNAL_ERR + * RadioError:INVALID_ARGUMENTS * RadioError:NO_MEMORY * RadioError:NO_RESOURCES * RadioError:CANCELLED