From c802e09390844e0129ca30843b9e25e7ae33cc11 Mon Sep 17 00:00:00 2001 From: Roshan Pius Date: Mon, 22 May 2017 14:16:06 -0700 Subject: [PATCH] wifi(vts): Add retry for HAL start Port of the retry logic added in HalDeviceManager for temporary IWifi.start() failures when invoked immediately after IWifi.stop(). Bug: 38342536 Test: Run VTS tests Change-Id: Ie58a08c45979bafa0c61fa1c8536a2c0a0cd8ed9 --- wifi/1.0/vts/functional/wifi_hidl_test_utils.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/wifi/1.0/vts/functional/wifi_hidl_test_utils.cpp b/wifi/1.0/vts/functional/wifi_hidl_test_utils.cpp index fefbd79e5a..e4382bce5d 100644 --- a/wifi/1.0/vts/functional/wifi_hidl_test_utils.cpp +++ b/wifi/1.0/vts/functional/wifi_hidl_test_utils.cpp @@ -36,6 +36,9 @@ using ::android::hardware::hidl_string; using ::android::hardware::hidl_vec; namespace { +constexpr uint32_t kHalStartRetryMaxCount = 5; +constexpr uint32_t kHalStartRetryIntervalInMs = 2; + bool findAnyModeSupportingIfaceType( IfaceType desired_type, const std::vector& modes, ChipModeId* mode_id) { @@ -92,7 +95,15 @@ sp getWifiChip() { if (!wifi.get()) { return nullptr; } - if (HIDL_INVOKE(wifi, start).code != WifiStatusCode::SUCCESS) { + uint32_t retry_count = 0; + auto status = HIDL_INVOKE(wifi, start); + while (retry_count < kHalStartRetryMaxCount && + status.code == WifiStatusCode::ERROR_NOT_AVAILABLE) { + retry_count++; + usleep(kHalStartRetryIntervalInMs * 1000); + status = HIDL_INVOKE(wifi, start); + } + if (status.code != WifiStatusCode::SUCCESS) { return nullptr; } const auto& status_and_chip_ids = HIDL_INVOKE(wifi, getChipIds);