diff --git a/automotive/evs/1.0/default/EvsCamera.cpp b/automotive/evs/1.0/default/EvsCamera.cpp index 148b7968b6..e0782ec779 100644 --- a/automotive/evs/1.0/default/EvsCamera.cpp +++ b/automotive/evs/1.0/default/EvsCamera.cpp @@ -311,9 +311,7 @@ unsigned EvsCamera::increaseAvailableFrames_Locked(unsigned numToAdd) { while (added < numToAdd) { buffer_handle_t memHandle = nullptr; - status_t result = alloc.allocate(mWidth, mHeight, - mFormat, 1, - mUsage, mUsage, + status_t result = alloc.allocate(mWidth, mHeight, mFormat, 1, mUsage, &memHandle, &mStride, 0, "EvsCamera"); if (result != NO_ERROR) { ALOGE("Error %d allocating %d x %d graphics buffer", result, mWidth, mHeight); diff --git a/automotive/evs/1.0/default/EvsDisplay.cpp b/automotive/evs/1.0/default/EvsDisplay.cpp index 9ad332a49e..9dd546d535 100644 --- a/automotive/evs/1.0/default/EvsDisplay.cpp +++ b/automotive/evs/1.0/default/EvsDisplay.cpp @@ -166,11 +166,9 @@ Return EvsDisplay::getTargetBuffer(getTargetBuffer_cb _hidl_cb) { // Allocate the buffer that will hold our displayable image buffer_handle_t handle = nullptr; GraphicBufferAllocator& alloc(GraphicBufferAllocator::get()); - status_t result = alloc.allocate(mBuffer.width, mBuffer.height, - mBuffer.format, 1, mBuffer.usage, - mBuffer.usage, &handle, - &mBuffer.stride, - 0, "EvsDisplay"); + status_t result = alloc.allocate( + mBuffer.width, mBuffer.height, mBuffer.format, 1, mBuffer.usage, + &handle, &mBuffer.stride, 0, "EvsDisplay"); if (result != NO_ERROR) { ALOGE("Error %d allocating %d x %d graphics buffer", result, mBuffer.width, mBuffer.height); diff --git a/camera/provider/2.4/vts/functional/Android.bp b/camera/provider/2.4/vts/functional/Android.bp index a0be5cbcde..85312c1a5d 100644 --- a/camera/provider/2.4/vts/functional/Android.bp +++ b/camera/provider/2.4/vts/functional/Android.bp @@ -33,7 +33,7 @@ cc_test { "libgui", "libui" ], - static_libs: ["VtsHalHidlTargetTestBase"], + static_libs: ["VtsHalHidlTargetTestBase", "libgrallocusage"], cflags: [ "-O0", "-g", diff --git a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp index b7ce858f2a..c8e44d3d49 100644 --- a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp +++ b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp @@ -15,28 +15,29 @@ */ #define LOG_TAG "camera_hidl_hal_test" -#include -#include -#include -#include "CameraParameters.h" -#include -#include -#include #include +#include +#include +#include +#include +#include +#include +#include #include #include -#include -#include -#include -#include "system/camera_metadata.h" #include #include -#include -#include -#include -#include #include +#include +#include #include +#include +#include +#include +#include +#include +#include "CameraParameters.h" +#include "system/camera_metadata.h" using ::android::hardware::Return; using ::android::hardware::Void; @@ -2480,11 +2481,12 @@ TEST_F(CameraHidlTest, processCaptureRequestPreview) { settings = req; }); ASSERT_TRUE(ret.isOk()); - sp gb = new GraphicBuffer(previewStream.width, - previewStream.height, - static_cast (halStreamConfig.streams[0].overrideFormat), - 1, halStreamConfig.streams[0].producerUsage, - halStreamConfig.streams[0].consumerUsage); + sp gb = new GraphicBuffer( + previewStream.width, previewStream.height, + static_cast(halStreamConfig.streams[0].overrideFormat), + 1, android_convertGralloc1To0Usage( + halStreamConfig.streams[0].producerUsage, + halStreamConfig.streams[0].consumerUsage)); ASSERT_NE(nullptr, gb.get()); StreamBuffer outputBuffer = {halStreamConfig.streams[0].id, bufferId, hidl_handle(gb->getNativeBuffer()->handle), @@ -2586,11 +2588,12 @@ TEST_F(CameraHidlTest, processCaptureRequestInvalidSinglePreview) { &session /*out*/, &previewStream /*out*/, &halStreamConfig /*out*/); - sp gb = new GraphicBuffer(previewStream.width, - previewStream.height, - static_cast (halStreamConfig.streams[0].overrideFormat), - 1, halStreamConfig.streams[0].producerUsage, - halStreamConfig.streams[0].consumerUsage); + sp gb = new GraphicBuffer( + previewStream.width, previewStream.height, + static_cast(halStreamConfig.streams[0].overrideFormat), + 1, android_convertGralloc1To0Usage( + halStreamConfig.streams[0].producerUsage, + halStreamConfig.streams[0].consumerUsage)); StreamBuffer outputBuffer = {halStreamConfig.streams[0].id, bufferId, hidl_handle(gb->getNativeBuffer()->handle), @@ -2706,11 +2709,12 @@ TEST_F(CameraHidlTest, flushPreviewRequest) { settings = req; }); ASSERT_TRUE(ret.isOk()); - sp gb = new GraphicBuffer(previewStream.width, - previewStream.height, - static_cast (halStreamConfig.streams[0].overrideFormat), - 1, halStreamConfig.streams[0].producerUsage, - halStreamConfig.streams[0].consumerUsage); + sp gb = new GraphicBuffer( + previewStream.width, previewStream.height, + static_cast(halStreamConfig.streams[0].overrideFormat), + 1, android_convertGralloc1To0Usage( + halStreamConfig.streams[0].producerUsage, + halStreamConfig.streams[0].consumerUsage)); ASSERT_NE(nullptr, gb.get()); StreamBuffer outputBuffer = {halStreamConfig.streams[0].id, bufferId, hidl_handle(gb->getNativeBuffer()->handle),