diff --git a/audio/aidl/vts/TestUtils.h b/audio/aidl/vts/TestUtils.h index 515b8a2a2f..0a5addc84c 100644 --- a/audio/aidl/vts/TestUtils.h +++ b/audio/aidl/vts/TestUtils.h @@ -104,11 +104,13 @@ inline ::testing::AssertionResult assertResultOrUnknownTransaction( EXPECT_PRED_FORMAT2(::android::hardware::audio::common::testing::detail::assertResult, \ expected, ret) -#define SKIP_TEST_IF_DATA_UNSUPPORTED(flags) \ - ({ \ - if ((flags).hwAcceleratorMode == Flags::HardwareAccelerator::TUNNEL || (flags).bypass) { \ - GTEST_SKIP() << "Skip data path for offload"; \ - } \ +#define SKIP_TEST_IF_DATA_UNSUPPORTED(flags) \ + ({ \ + if ((flags).hwAcceleratorMode == \ + aidl::android::hardware::audio::effect::Flags::HardwareAccelerator::TUNNEL || \ + (flags).bypass) { \ + GTEST_SKIP() << "Skip data path for offload"; \ + } \ }) // Test that the transaction status 'isOk' if it is a known transaction diff --git a/audio/aidl/vts/VtsHalAudioEffectFactoryTargetTest.cpp b/audio/aidl/vts/VtsHalAudioEffectFactoryTargetTest.cpp index 21df163c5c..a19aa56ef1 100644 --- a/audio/aidl/vts/VtsHalAudioEffectFactoryTargetTest.cpp +++ b/audio/aidl/vts/VtsHalAudioEffectFactoryTargetTest.cpp @@ -65,7 +65,7 @@ class EffectFactoryTest : public testing::TestWithParam { } } - std::string kServiceName = GetParam(); + const std::string kServiceName = GetParam(); std::shared_ptr mEffectFactory; std::vector> mEffects; const Descriptor::Identity kNullId = {.uuid = getEffectUuidNull()}; @@ -118,6 +118,10 @@ class EffectFactoryTest : public testing::TestWithParam { mEffectFactory = IFactory::fromBinder(mBinderUtil.connectToService(kServiceName)); ASSERT_NE(mEffectFactory, nullptr); } + void restartAndGetFactory() { + mEffectFactory = IFactory::fromBinder(mBinderUtil.restartService()); + ASSERT_NE(mEffectFactory, nullptr); + } }; TEST_P(EffectFactoryTest, SetupAndTearDown) { @@ -126,8 +130,7 @@ TEST_P(EffectFactoryTest, SetupAndTearDown) { TEST_P(EffectFactoryTest, CanBeRestarted) { ASSERT_NE(mEffectFactory, nullptr); - mEffectFactory = IFactory::fromBinder(mBinderUtil.restartService()); - ASSERT_NE(mEffectFactory, nullptr); + restartAndGetFactory(); } /** @@ -249,9 +252,7 @@ TEST_P(EffectFactoryTest, CreateDestroyWithRestart) { EXPECT_NE(descs.size(), 0UL); creatAndDestroyDescs(descs); - mEffectFactory = IFactory::fromBinder(mBinderUtil.restartService()); - ASSERT_NE(mEffectFactory, nullptr); - + restartAndGetFactory(); connectAndGetFactory(); creatAndDestroyDescs(descs); } @@ -263,9 +264,7 @@ TEST_P(EffectFactoryTest, EffectInvalidAfterRestart) { EXPECT_NE(descs.size(), 0UL); std::vector> effects = createWithDescs(descs); - mEffectFactory = IFactory::fromBinder(mBinderUtil.restartService()); - ASSERT_NE(mEffectFactory, nullptr); - + restartAndGetFactory(); connectAndGetFactory(); destroyEffects(effects, EX_ILLEGAL_ARGUMENT); } diff --git a/audio/aidl/vts/VtsHalBassBoostTargetTest.cpp b/audio/aidl/vts/VtsHalBassBoostTargetTest.cpp index b54b44233f..4cb1f496d4 100644 --- a/audio/aidl/vts/VtsHalBassBoostTargetTest.cpp +++ b/audio/aidl/vts/VtsHalBassBoostTargetTest.cpp @@ -166,6 +166,7 @@ class BassBoostDataTest : public ::testing::TestWithParamgetInterfaceVersion(&version).isOk() && version < kMinDataTestHalVersion) { @@ -173,7 +174,10 @@ class BassBoostDataTest : public ::testing::TestWithParam& testFrequencies, diff --git a/audio/aidl/vts/VtsHalDownmixTargetTest.cpp b/audio/aidl/vts/VtsHalDownmixTargetTest.cpp index 360bf2671f..ef77f4d51e 100644 --- a/audio/aidl/vts/VtsHalDownmixTargetTest.cpp +++ b/audio/aidl/vts/VtsHalDownmixTargetTest.cpp @@ -230,6 +230,7 @@ class DownmixFoldDataTest : public ::testing::TestWithParamgetInterfaceVersion(&version).isOk() && version < kMinDataTestHalVersion) { @@ -241,7 +242,10 @@ class DownmixFoldDataTest : public ::testing::TestWithParam(mOpenEffectReturn.outputDataMQ); } - void TearDown() override { TearDownLoudnessEnhancer(); } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownLoudnessEnhancer(); + } // Fill inputBuffer with random values between -kMaxAudioSample to kMaxAudioSample void generateInputBuffer() { diff --git a/audio/aidl/vts/VtsHalVolumeTargetTest.cpp b/audio/aidl/vts/VtsHalVolumeTargetTest.cpp index 059d6ab984..1c1489deb5 100644 --- a/audio/aidl/vts/VtsHalVolumeTargetTest.cpp +++ b/audio/aidl/vts/VtsHalVolumeTargetTest.cpp @@ -163,8 +163,14 @@ class VolumeDataTest : public ::testing::TestWithParam, // Convert Decibel value to Percentage int percentageDb(float level) { return std::round((1 - (pow(10, level / 20))) * 100); } - void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpVolumeControl()); } - void TearDown() override { TearDownVolumeControl(); } + void SetUp() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + ASSERT_NO_FATAL_FAILURE(SetUpVolumeControl()); + } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownVolumeControl(); + } static constexpr int kMaxAudioSample = 1; static constexpr int kTransitionDuration = 300;