diff --git a/neuralnetworks/utils/common/include/nnapi/hal/HandleError.h b/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/HandleError.h similarity index 79% rename from neuralnetworks/utils/common/include/nnapi/hal/HandleError.h rename to neuralnetworks/1.0/utils/include/nnapi/hal/1.0/HandleError.h index e51f916792..8e02633b41 100644 --- a/neuralnetworks/utils/common/include/nnapi/hal/HandleError.h +++ b/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/HandleError.h @@ -14,8 +14,8 @@ * limitations under the License. */ -#ifndef ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_UTILS_COMMON_HANDLE_ERROR_H -#define ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_UTILS_COMMON_HANDLE_ERROR_H +#ifndef ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_1_0_UTILS_HANDLE_ERROR_H +#define ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_1_0_UTILS_HANDLE_ERROR_H #include #include @@ -27,7 +27,7 @@ namespace android::hardware::neuralnetworks::utils { template -nn::GeneralResult handleTransportError(const hardware::Return& ret) { +nn::GeneralResult handleTransportError(const Return& ret) { if (ret.isDeadObject()) { return nn::error(nn::ErrorStatus::DEAD_OBJECT) << "Return<>::isDeadObject returned true: " << ret.description(); @@ -52,13 +52,13 @@ nn::GeneralResult handleTransportError(const hardware::Return& ret) std::move(result).value(); \ }) -#define HANDLE_HAL_STATUS(status) \ - if (const auto canonical = ::android::nn::convert(status).value_or( \ - ::android::nn::ErrorStatus::GENERAL_FAILURE); \ - canonical == ::android::nn::ErrorStatus::NONE) { \ - } else \ +#define HANDLE_STATUS_HIDL(status) \ + if (const ::android::nn::ErrorStatus canonical = ::android::nn::convert(status).value_or( \ + ::android::nn::ErrorStatus::GENERAL_FAILURE); \ + canonical == ::android::nn::ErrorStatus::NONE) { \ + } else \ return NN_ERROR(canonical) } // namespace android::hardware::neuralnetworks::utils -#endif // ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_UTILS_COMMON_HANDLE_ERROR_H +#endif // ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_1_0_UTILS_HANDLE_ERROR_H diff --git a/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/Utils.h b/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/Utils.h index 360b338c0e..5c1480e83b 100644 --- a/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/Utils.h +++ b/neuralnetworks/1.0/utils/include/nnapi/hal/1.0/Utils.h @@ -25,7 +25,6 @@ #include #include #include -#include namespace android::hardware::neuralnetworks::V1_0::utils { diff --git a/neuralnetworks/1.0/utils/src/Callbacks.cpp b/neuralnetworks/1.0/utils/src/Callbacks.cpp index 5fb9e928a1..7b478ae3c6 100644 --- a/neuralnetworks/1.0/utils/src/Callbacks.cpp +++ b/neuralnetworks/1.0/utils/src/Callbacks.cpp @@ -17,6 +17,7 @@ #include "Callbacks.h" #include "Conversions.h" +#include "HandleError.h" #include "PreparedModel.h" #include "ProtectCallback.h" #include "Utils.h" @@ -28,7 +29,6 @@ #include #include #include -#include #include #include @@ -40,19 +40,19 @@ namespace android::hardware::neuralnetworks::V1_0::utils { nn::GeneralResult> supportedOperationsCallback( ErrorStatus status, const hidl_vec& supportedOperations) { - HANDLE_HAL_STATUS(status) << "get supported operations failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "get supported operations failed with " << toString(status); return supportedOperations; } nn::GeneralResult prepareModelCallback( ErrorStatus status, const sp& preparedModel) { - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return NN_TRY(PreparedModel::create(preparedModel)); } nn::ExecutionResult, nn::Timing>> executionCallback( ErrorStatus status) { - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); return {}; } diff --git a/neuralnetworks/1.0/utils/src/Device.cpp b/neuralnetworks/1.0/utils/src/Device.cpp index 404a92fcbb..49913a2584 100644 --- a/neuralnetworks/1.0/utils/src/Device.cpp +++ b/neuralnetworks/1.0/utils/src/Device.cpp @@ -18,6 +18,7 @@ #include "Callbacks.h" #include "Conversions.h" +#include "HandleError.h" #include "ProtectCallback.h" #include "Utils.h" @@ -30,7 +31,6 @@ #include #include #include -#include #include #include @@ -47,7 +47,7 @@ namespace { nn::GeneralResult capabilitiesCallback(ErrorStatus status, const Capabilities& capabilities) { - HANDLE_HAL_STATUS(status) << "getting capabilities failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getting capabilities failed with " << toString(status); return nn::convert(capabilities); } @@ -156,7 +156,7 @@ nn::GeneralResult Device::prepareModel( const auto ret = kDevice->prepareModel(hidlModel, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return cb->get(); } diff --git a/neuralnetworks/1.0/utils/src/Execution.cpp b/neuralnetworks/1.0/utils/src/Execution.cpp index 056b0414ca..6e105a6791 100644 --- a/neuralnetworks/1.0/utils/src/Execution.cpp +++ b/neuralnetworks/1.0/utils/src/Execution.cpp @@ -18,6 +18,7 @@ #include "Callbacks.h" #include "Conversions.h" +#include "HandleError.h" #include "ProtectCallback.h" #include "Utils.h" @@ -28,7 +29,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/1.0/utils/src/PreparedModel.cpp b/neuralnetworks/1.0/utils/src/PreparedModel.cpp index b332182700..00e7d22916 100644 --- a/neuralnetworks/1.0/utils/src/PreparedModel.cpp +++ b/neuralnetworks/1.0/utils/src/PreparedModel.cpp @@ -20,6 +20,7 @@ #include "Callbacks.h" #include "Conversions.h" #include "Execution.h" +#include "HandleError.h" #include "ProtectCallback.h" #include "Utils.h" @@ -29,7 +30,6 @@ #include #include #include -#include #include #include @@ -84,7 +84,7 @@ PreparedModel::executeInternal(const V1_0::Request& request, const auto ret = kPreparedModel->execute(request, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); auto result = NN_TRY(cb->get()); if (relocation.output) { diff --git a/neuralnetworks/1.0/utils/src/ProtectCallback.cpp b/neuralnetworks/1.0/utils/src/ProtectCallback.cpp index 18e1f3bf0b..89539b5f34 100644 --- a/neuralnetworks/1.0/utils/src/ProtectCallback.cpp +++ b/neuralnetworks/1.0/utils/src/ProtectCallback.cpp @@ -22,7 +22,8 @@ #include #include #include -#include + +#include "HandleError.h" #include #include diff --git a/neuralnetworks/1.1/utils/include/nnapi/hal/1.1/Utils.h b/neuralnetworks/1.1/utils/include/nnapi/hal/1.1/Utils.h index 09d9fe89a7..4660ff732f 100644 --- a/neuralnetworks/1.1/utils/include/nnapi/hal/1.1/Utils.h +++ b/neuralnetworks/1.1/utils/include/nnapi/hal/1.1/Utils.h @@ -26,7 +26,6 @@ #include #include #include -#include namespace android::hardware::neuralnetworks::V1_1::utils { diff --git a/neuralnetworks/1.1/utils/src/Device.cpp b/neuralnetworks/1.1/utils/src/Device.cpp index 0e239cbe82..7d54cabeb9 100644 --- a/neuralnetworks/1.1/utils/src/Device.cpp +++ b/neuralnetworks/1.1/utils/src/Device.cpp @@ -29,9 +29,9 @@ #include #include #include +#include #include #include -#include #include #include @@ -47,7 +47,7 @@ namespace { nn::GeneralResult capabilitiesCallback(V1_0::ErrorStatus status, const Capabilities& capabilities) { - HANDLE_HAL_STATUS(status) << "getting capabilities failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getting capabilities failed with " << toString(status); return nn::convert(capabilities); } @@ -157,7 +157,7 @@ nn::GeneralResult Device::prepareModel( const auto ret = kDevice->prepareModel_1_1(hidlModel, hidlPreference, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return cb->get(); } diff --git a/neuralnetworks/1.2/utils/include/nnapi/hal/1.2/Utils.h b/neuralnetworks/1.2/utils/include/nnapi/hal/1.2/Utils.h index 5c3b8a743c..23e336a69a 100644 --- a/neuralnetworks/1.2/utils/include/nnapi/hal/1.2/Utils.h +++ b/neuralnetworks/1.2/utils/include/nnapi/hal/1.2/Utils.h @@ -28,7 +28,6 @@ #include #include #include -#include #include diff --git a/neuralnetworks/1.2/utils/src/Callbacks.cpp b/neuralnetworks/1.2/utils/src/Callbacks.cpp index c855b172e9..cb61f21775 100644 --- a/neuralnetworks/1.2/utils/src/Callbacks.cpp +++ b/neuralnetworks/1.2/utils/src/Callbacks.cpp @@ -29,10 +29,10 @@ #include #include #include +#include #include #include #include -#include #include #include @@ -62,7 +62,7 @@ convertExecutionGeneralResultsHelper(const hidl_vec& outputShapes, nn::GeneralResult prepareModelCallback( V1_0::ErrorStatus status, const sp& preparedModel) { - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return NN_TRY(PreparedModel::create(preparedModel, /*executeSynchronously=*/true)); } @@ -74,7 +74,7 @@ nn::ExecutionResult, nn::Timing>> executi return NN_ERROR(nn::ErrorStatus::OUTPUT_INSUFFICIENT_SIZE, std::move(canonicalOutputShapes)) << "execution failed with " << toString(status); } - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); return convertExecutionGeneralResultsHelper(outputShapes, timing); } diff --git a/neuralnetworks/1.2/utils/src/Conversions.cpp b/neuralnetworks/1.2/utils/src/Conversions.cpp index ef5056b5fe..838d9c4717 100644 --- a/neuralnetworks/1.2/utils/src/Conversions.cpp +++ b/neuralnetworks/1.2/utils/src/Conversions.cpp @@ -28,7 +28,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/1.2/utils/src/Device.cpp b/neuralnetworks/1.2/utils/src/Device.cpp index 42c2a61fab..f12669a6dc 100644 --- a/neuralnetworks/1.2/utils/src/Device.cpp +++ b/neuralnetworks/1.2/utils/src/Device.cpp @@ -30,10 +30,10 @@ #include #include #include +#include #include #include #include -#include #include #include @@ -49,31 +49,31 @@ namespace { nn::GeneralResult capabilitiesCallback(V1_0::ErrorStatus status, const Capabilities& capabilities) { - HANDLE_HAL_STATUS(status) << "getting capabilities failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getting capabilities failed with " << toString(status); return nn::convert(capabilities); } nn::GeneralResult versionStringCallback(V1_0::ErrorStatus status, const hidl_string& versionString) { - HANDLE_HAL_STATUS(status) << "getVersionString failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getVersionString failed with " << toString(status); return versionString; } nn::GeneralResult deviceTypeCallback(V1_0::ErrorStatus status, DeviceType deviceType) { - HANDLE_HAL_STATUS(status) << "getDeviceType failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getDeviceType failed with " << toString(status); return nn::convert(deviceType); } nn::GeneralResult> supportedExtensionsCallback( V1_0::ErrorStatus status, const hidl_vec& extensions) { - HANDLE_HAL_STATUS(status) << "getExtensions failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getExtensions failed with " << toString(status); return nn::convert(extensions); } nn::GeneralResult> numberOfCacheFilesNeededCallback( V1_0::ErrorStatus status, uint32_t numModelCache, uint32_t numDataCache) { - HANDLE_HAL_STATUS(status) << "getNumberOfCacheFilesNeeded failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getNumberOfCacheFilesNeeded failed with " << toString(status); if (numModelCache > nn::kMaxNumberOfCacheFiles) { return NN_ERROR() << "getNumberOfCacheFilesNeeded returned numModelCache files greater " "than allowed max (" @@ -254,7 +254,7 @@ nn::GeneralResult Device::prepareModel( const auto ret = kDevice->prepareModel_1_2(hidlModel, hidlPreference, hidlModelCache, hidlDataCache, hidlToken, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return cb->get(); } @@ -271,7 +271,7 @@ nn::GeneralResult Device::prepareModelFromCache( const auto ret = kDevice->prepareModelFromCache(hidlModelCache, hidlDataCache, hidlToken, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation from cache failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation from cache failed with " << toString(status); return cb->get(); } diff --git a/neuralnetworks/1.2/utils/src/Execution.cpp b/neuralnetworks/1.2/utils/src/Execution.cpp index 18d1c90edd..320b0e1e2f 100644 --- a/neuralnetworks/1.2/utils/src/Execution.cpp +++ b/neuralnetworks/1.2/utils/src/Execution.cpp @@ -29,7 +29,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/1.2/utils/src/ExecutionBurstController.cpp b/neuralnetworks/1.2/utils/src/ExecutionBurstController.cpp index 98a75fa785..a8ded9e95c 100644 --- a/neuralnetworks/1.2/utils/src/ExecutionBurstController.cpp +++ b/neuralnetworks/1.2/utils/src/ExecutionBurstController.cpp @@ -28,9 +28,9 @@ #include #include #include +#include #include #include -#include #include #include @@ -82,8 +82,8 @@ class BurstExecution final : public nn::IExecution, nn::GeneralResult> executionBurstResultCallback( V1_0::ErrorStatus status, const sp& burstContext) { - HANDLE_HAL_STATUS(status) << "IPreparedModel::configureExecutionBurst failed with status " - << toString(status); + HANDLE_STATUS_HIDL(status) << "IPreparedModel::configureExecutionBurst failed with status " + << toString(status); if (burstContext == nullptr) { return NN_ERROR(nn::ErrorStatus::GENERAL_FAILURE) << "IPreparedModel::configureExecutionBurst returned nullptr for burst"; diff --git a/neuralnetworks/1.2/utils/src/ExecutionBurstServer.cpp b/neuralnetworks/1.2/utils/src/ExecutionBurstServer.cpp index 52cabd8b96..f30b662182 100644 --- a/neuralnetworks/1.2/utils/src/ExecutionBurstServer.cpp +++ b/neuralnetworks/1.2/utils/src/ExecutionBurstServer.cpp @@ -27,8 +27,8 @@ #include #include #include +#include #include -#include #include #include @@ -50,7 +50,7 @@ constexpr V1_2::Timing kNoTiming = {std::numeric_limits::max(), nn::GeneralResult> getMemoriesCallback( V1_0::ErrorStatus status, const hidl_vec& memories) { - HANDLE_HAL_STATUS(status) << "getting burst memories failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getting burst memories failed with " << toString(status); std::vector canonicalMemories; canonicalMemories.reserve(memories.size()); for (const auto& memory : memories) { diff --git a/neuralnetworks/1.2/utils/src/PreparedModel.cpp b/neuralnetworks/1.2/utils/src/PreparedModel.cpp index d11cdc2d2a..b8a5ae087c 100644 --- a/neuralnetworks/1.2/utils/src/PreparedModel.cpp +++ b/neuralnetworks/1.2/utils/src/PreparedModel.cpp @@ -31,9 +31,9 @@ #include #include #include +#include #include #include -#include #include #include @@ -82,7 +82,7 @@ PreparedModel::executeAsynchronously(const V1_0::Request& request, MeasureTiming const auto ret = kPreparedModel->execute_1_2(request, measure, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); if (status != V1_0::ErrorStatus::OUTPUT_INSUFFICIENT_SIZE) { - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); } return cb->get(); diff --git a/neuralnetworks/1.3/utils/include/nnapi/hal/1.3/Utils.h b/neuralnetworks/1.3/utils/include/nnapi/hal/1.3/Utils.h index 28525bd450..2812db2546 100644 --- a/neuralnetworks/1.3/utils/include/nnapi/hal/1.3/Utils.h +++ b/neuralnetworks/1.3/utils/include/nnapi/hal/1.3/Utils.h @@ -30,7 +30,6 @@ #include #include #include -#include namespace android::hardware::neuralnetworks::V1_3::utils { diff --git a/neuralnetworks/1.3/utils/src/Buffer.cpp b/neuralnetworks/1.3/utils/src/Buffer.cpp index ada526573b..34925eacfc 100644 --- a/neuralnetworks/1.3/utils/src/Buffer.cpp +++ b/neuralnetworks/1.3/utils/src/Buffer.cpp @@ -25,7 +25,7 @@ #include #include #include -#include +#include #include "Conversions.h" #include "Utils.h" @@ -66,7 +66,7 @@ nn::GeneralResult Buffer::copyTo(const nn::SharedMemory& dst) const { const auto ret = kBuffer->copyTo(hidlDst); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "IBuffer::copyTo failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "IBuffer::copyTo failed with " << toString(status); return {}; } @@ -78,7 +78,7 @@ nn::GeneralResult Buffer::copyFrom(const nn::SharedMemory& src, const auto ret = kBuffer->copyFrom(hidlSrc, hidlDimensions); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "IBuffer::copyFrom failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "IBuffer::copyFrom failed with " << toString(status); return {}; } diff --git a/neuralnetworks/1.3/utils/src/Callbacks.cpp b/neuralnetworks/1.3/utils/src/Callbacks.cpp index b4fe487422..f0638626f6 100644 --- a/neuralnetworks/1.3/utils/src/Callbacks.cpp +++ b/neuralnetworks/1.3/utils/src/Callbacks.cpp @@ -30,13 +30,13 @@ #include #include #include +#include #include #include #include #include #include #include -#include #include #include @@ -71,13 +71,13 @@ convertExecutionGeneralResultsHelper(const hidl_vec& outputSh nn::GeneralResult> supportedOperationsCallback( ErrorStatus status, const hidl_vec& supportedOperations) { - HANDLE_HAL_STATUS(status) << "get supported operations failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "get supported operations failed with " << toString(status); return supportedOperations; } nn::GeneralResult prepareModelCallback( ErrorStatus status, const sp& preparedModel) { - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return NN_TRY(PreparedModel::create(preparedModel, /*executeSynchronously=*/true)); } @@ -90,7 +90,7 @@ nn::ExecutionResult, nn::Timing>> executi return NN_ERROR(nn::ErrorStatus::OUTPUT_INSUFFICIENT_SIZE, std::move(canonicalOutputShapes)) << "execution failed with " << toString(status); } - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); return convertExecutionGeneralResultsHelper(outputShapes, timing); } diff --git a/neuralnetworks/1.3/utils/src/Conversions.cpp b/neuralnetworks/1.3/utils/src/Conversions.cpp index c885d60ee9..a1d414c700 100644 --- a/neuralnetworks/1.3/utils/src/Conversions.cpp +++ b/neuralnetworks/1.3/utils/src/Conversions.cpp @@ -28,7 +28,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/1.3/utils/src/Device.cpp b/neuralnetworks/1.3/utils/src/Device.cpp index 462d557e53..a73ce82ed2 100644 --- a/neuralnetworks/1.3/utils/src/Device.cpp +++ b/neuralnetworks/1.3/utils/src/Device.cpp @@ -33,13 +33,13 @@ #include #include #include +#include #include #include #include #include #include #include -#include #include #include @@ -72,7 +72,7 @@ nn::GeneralResult>> convert( nn::GeneralResult capabilitiesCallback(ErrorStatus status, const Capabilities& capabilities) { - HANDLE_HAL_STATUS(status) << "getting capabilities failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "getting capabilities failed with " << toString(status); return nn::convert(capabilities); } @@ -89,7 +89,7 @@ nn::GeneralResult getCapabilitiesFrom(V1_3::IDevice* device) { nn::GeneralResult allocationCallback(ErrorStatus status, const sp& buffer, uint32_t token) { - HANDLE_HAL_STATUS(status) << "IDevice::allocate failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "IDevice::allocate failed with " << toString(status); return Buffer::create(buffer, static_cast(token)); } @@ -208,7 +208,7 @@ nn::GeneralResult Device::prepareModel( kDevice->prepareModel_1_3(hidlModel, hidlPreference, hidlPriority, hidlDeadline, hidlModelCache, hidlDataCache, hidlToken, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation failed with " << toString(status); return cb->get(); } @@ -227,7 +227,7 @@ nn::GeneralResult Device::prepareModelFromCache( const auto ret = kDevice->prepareModelFromCache_1_3(hidlDeadline, hidlModelCache, hidlDataCache, hidlToken, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); - HANDLE_HAL_STATUS(status) << "model preparation from cache failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "model preparation from cache failed with " << toString(status); return cb->get(); } diff --git a/neuralnetworks/1.3/utils/src/Execution.cpp b/neuralnetworks/1.3/utils/src/Execution.cpp index 467d87d3aa..0ec7f56d37 100644 --- a/neuralnetworks/1.3/utils/src/Execution.cpp +++ b/neuralnetworks/1.3/utils/src/Execution.cpp @@ -29,7 +29,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/1.3/utils/src/PreparedModel.cpp b/neuralnetworks/1.3/utils/src/PreparedModel.cpp index 792665ed1e..2c81cb2ad5 100644 --- a/neuralnetworks/1.3/utils/src/PreparedModel.cpp +++ b/neuralnetworks/1.3/utils/src/PreparedModel.cpp @@ -30,12 +30,12 @@ #include #include #include +#include #include #include #include #include #include -#include #include #include @@ -50,14 +50,14 @@ namespace { nn::GeneralResult> convertFencedExecutionCallbackResults( ErrorStatus status, const V1_2::Timing& timingLaunched, const V1_2::Timing& timingFenced) { - HANDLE_HAL_STATUS(status) << "fenced execution callback info failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "fenced execution callback info failed with " << toString(status); return std::make_pair(NN_TRY(nn::convert(timingLaunched)), NN_TRY(nn::convert(timingFenced))); } nn::GeneralResult> fencedExecutionCallback( ErrorStatus status, const hidl_handle& syncFence, const sp& callback) { - HANDLE_HAL_STATUS(status) << "fenced execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "fenced execution failed with " << toString(status); auto resultSyncFence = nn::SyncFence::createAsSignaled(); if (syncFence.getNativeHandle() != nullptr) { @@ -127,7 +127,7 @@ PreparedModel::executeAsynchronously(const Request& request, V1_2::MeasureTiming kPreparedModel->execute_1_3(request, measure, deadline, loopTimeoutDuration, cb); const auto status = HANDLE_TRANSPORT_FAILURE(ret); if (status != ErrorStatus::OUTPUT_INSUFFICIENT_SIZE) { - HANDLE_HAL_STATUS(status) << "execution failed with " << toString(status); + HANDLE_STATUS_HIDL(status) << "execution failed with " << toString(status); } return cb->get(); diff --git a/neuralnetworks/aidl/utils/Android.bp b/neuralnetworks/aidl/utils/Android.bp index cb67b84bf2..2ff7534184 100644 --- a/neuralnetworks/aidl/utils/Android.bp +++ b/neuralnetworks/aidl/utils/Android.bp @@ -40,7 +40,6 @@ cc_library_static { shared_libs: [ "android.hardware.neuralnetworks-V2-ndk", "libbinder_ndk", - "libhidlbase", ], target: { android: { diff --git a/neuralnetworks/aidl/utils/include/nnapi/hal/aidl/Utils.h b/neuralnetworks/aidl/utils/include/nnapi/hal/aidl/Utils.h index 1b149e452b..3a45f8d3ea 100644 --- a/neuralnetworks/aidl/utils/include/nnapi/hal/aidl/Utils.h +++ b/neuralnetworks/aidl/utils/include/nnapi/hal/aidl/Utils.h @@ -24,7 +24,6 @@ #include #include #include -#include namespace aidl::android::hardware::neuralnetworks::utils { @@ -75,6 +74,13 @@ nn::GeneralResult handleTransportError(const ndk::ScopedAStatus& ret); for (const auto status = handleTransportError(ret); !status.ok();) \ return NN_ERROR(status.error().code) << status.error().message << ": " +#define HANDLE_STATUS_AIDL(status) \ + if (const ::android::nn::ErrorStatus canonical = ::android::nn::convert(status).value_or( \ + ::android::nn::ErrorStatus::GENERAL_FAILURE); \ + canonical == ::android::nn::ErrorStatus::NONE) { \ + } else \ + return NN_ERROR(canonical) + } // namespace aidl::android::hardware::neuralnetworks::utils #endif // ANDROID_HARDWARE_INTERFACES_NEURALNETWORKS_AIDL_UTILS_H diff --git a/neuralnetworks/aidl/utils/src/Burst.cpp b/neuralnetworks/aidl/utils/src/Burst.cpp index c59c10bedd..fb00b264e3 100644 --- a/neuralnetworks/aidl/utils/src/Burst.cpp +++ b/neuralnetworks/aidl/utils/src/Burst.cpp @@ -26,7 +26,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/aidl/utils/src/Callbacks.cpp b/neuralnetworks/aidl/utils/src/Callbacks.cpp index 8055665228..a32147734c 100644 --- a/neuralnetworks/aidl/utils/src/Callbacks.cpp +++ b/neuralnetworks/aidl/utils/src/Callbacks.cpp @@ -38,7 +38,7 @@ namespace { // nn::Version::ANDROID_S. On failure, this function returns with the appropriate nn::GeneralError. nn::GeneralResult prepareModelCallback( ErrorStatus status, const std::shared_ptr& preparedModel) { - HANDLE_HAL_STATUS(status) << "model preparation failed with " << toString(status); + HANDLE_STATUS_AIDL(status) << "model preparation failed with " << toString(status); return NN_TRY(PreparedModel::create(preparedModel)); } diff --git a/neuralnetworks/aidl/utils/src/Conversions.cpp b/neuralnetworks/aidl/utils/src/Conversions.cpp index ddff3f2cb7..45628c8e73 100644 --- a/neuralnetworks/aidl/utils/src/Conversions.cpp +++ b/neuralnetworks/aidl/utils/src/Conversions.cpp @@ -34,7 +34,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/aidl/utils/src/Execution.cpp b/neuralnetworks/aidl/utils/src/Execution.cpp index 13d4f32048..94edd90c89 100644 --- a/neuralnetworks/aidl/utils/src/Execution.cpp +++ b/neuralnetworks/aidl/utils/src/Execution.cpp @@ -25,7 +25,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/aidl/utils/src/PreparedModel.cpp b/neuralnetworks/aidl/utils/src/PreparedModel.cpp index 0769016b4c..f25c2c8825 100644 --- a/neuralnetworks/aidl/utils/src/PreparedModel.cpp +++ b/neuralnetworks/aidl/utils/src/PreparedModel.cpp @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -51,7 +50,7 @@ nn::GeneralResult, nn::Timing>> convertEx nn::GeneralResult> convertFencedExecutionResults( ErrorStatus status, const aidl_hal::Timing& timingLaunched, const aidl_hal::Timing& timingFenced) { - HANDLE_HAL_STATUS(status) << "fenced execution callback info failed with " << toString(status); + HANDLE_STATUS_AIDL(status) << "fenced execution callback info failed with " << toString(status); return std::make_pair(NN_TRY(nn::convert(timingLaunched)), NN_TRY(nn::convert(timingFenced))); } diff --git a/neuralnetworks/utils/adapter/src/PreparedModel.cpp b/neuralnetworks/utils/adapter/src/PreparedModel.cpp index 7397defb34..40c0888cda 100644 --- a/neuralnetworks/utils/adapter/src/PreparedModel.cpp +++ b/neuralnetworks/utils/adapter/src/PreparedModel.cpp @@ -36,7 +36,6 @@ #include #include #include -#include #include #include diff --git a/neuralnetworks/utils/common/Android.bp b/neuralnetworks/utils/common/Android.bp index 6f07be9207..e02a202574 100644 --- a/neuralnetworks/utils/common/Android.bp +++ b/neuralnetworks/utils/common/Android.bp @@ -30,13 +30,8 @@ cc_library_static { local_include_dirs: ["include/nnapi/hal"], export_include_dirs: ["include"], cflags: ["-Wthread-safety"], - static_libs: [ - "neuralnetworks_types", - ], - shared_libs: [ - "libhidlbase", - "libbinder_ndk", - ], + static_libs: ["neuralnetworks_types"], + shared_libs: ["libbinder_ndk"], } cc_test { diff --git a/neuralnetworks/utils/common/src/CommonUtils.cpp b/neuralnetworks/utils/common/src/CommonUtils.cpp index b66fbd17ef..b2498818f8 100644 --- a/neuralnetworks/utils/common/src/CommonUtils.cpp +++ b/neuralnetworks/utils/common/src/CommonUtils.cpp @@ -16,8 +16,6 @@ #include "CommonUtils.h" -#include "HandleError.h" - #include #include #include