From ebeaa36f431cc360d4fc8e5d3ef99b74cf1ce2de Mon Sep 17 00:00:00 2001 From: Shikha Panwar Date: Fri, 22 Dec 2023 10:46:24 +0000 Subject: [PATCH] Secretkeeper: Disable a replay protection VTS This test does not account for potentially missing Sk HAL. Ideally, the test should pass on those devices too (since Sk is an optional HAL at the moment). This test uses should_panic expecting the client code to panic on processing the message, but that code is never executed because the backend is not present & the method doesn't panic & the test fails. As a mitigation, #ignore the test. Bug: 317416663 Test: VTS show "IGNORED" Change-Id: I2f1bb45361943f22d8cadc929059c65cb3120f3f --- security/secretkeeper/aidl/vts/secretkeeper_test_client.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/security/secretkeeper/aidl/vts/secretkeeper_test_client.rs b/security/secretkeeper/aidl/vts/secretkeeper_test_client.rs index 994f581c27..c457d248ca 100644 --- a/security/secretkeeper/aidl/vts/secretkeeper_test_client.rs +++ b/security/secretkeeper/aidl/vts/secretkeeper_test_client.rs @@ -513,6 +513,8 @@ fn secret_management_replay_protection_seq_num_per_session() { // This test checks that Secretkeeper rejects requests with out of order [`RequestSeqNum`] #[test] +// TODO(b/317416663): This test fails, when HAL is not present in the device. Refactor to fix this. +#[ignore] #[should_panic] fn secret_management_replay_protection_out_of_seq_req_not_accepted() { let sk_client = setup_client!();