diff --git a/evs/1.0/default/EvsEnumerator.cpp b/evs/1.0/default/EvsEnumerator.cpp index 9f380410c5..ba8da00d4b 100644 --- a/evs/1.0/default/EvsEnumerator.cpp +++ b/evs/1.0/default/EvsEnumerator.cpp @@ -62,8 +62,7 @@ Return EvsEnumerator::getCameraList(getCameraList_cb _hidl_cb) { return Void(); } -Return EvsEnumerator::openCamera(const hidl_string& cameraId, - openCamera_cb callback) { +Return> EvsEnumerator::openCamera(const hidl_string& cameraId) { ALOGD("openCamera"); // Find the named camera @@ -78,20 +77,18 @@ Return EvsEnumerator::openCamera(const hidl_string& cameraId, if (!pRecord) { ALOGE("Requested camera %s not found", cameraId.c_str()); - callback(nullptr); + return nullptr; } else if (pRecord->inUse) { ALOGE("Cannot open camera %s which is already in use", cameraId.c_str()); - callback(nullptr); + return nullptr; } else { /* TODO(b/33492405): Do this, When HIDL can give us back a recognizable pointer pRecord->inUse = true; */ - callback(pRecord->pCamera); + return(pRecord->pCamera); } - - return Void(); } Return EvsEnumerator::closeCamera(const ::android::sp& camera) { @@ -112,22 +109,20 @@ Return EvsEnumerator::closeCamera(const ::android::sp& camera) return Void(); } -Return EvsEnumerator::openDisplay(openDisplay_cb callback) { +Return> EvsEnumerator::openDisplay() { ALOGD("openDisplay"); // If we already have a display active, then this request must be denied if (mActiveDisplay != nullptr) { ALOGW("Rejecting openDisplay request the display is already in use."); - callback(nullptr); + return nullptr; } else { // Create a new display interface and return it mActiveDisplay = new EvsDisplay(); ALOGD("Returning new EvsDisplay object %p", mActiveDisplay.get()); - callback(mActiveDisplay); + return mActiveDisplay; } - - return Void(); } Return EvsEnumerator::closeDisplay(const ::android::sp& display) { diff --git a/evs/1.0/default/EvsEnumerator.h b/evs/1.0/default/EvsEnumerator.h index 69caa170ac..90df837748 100644 --- a/evs/1.0/default/EvsEnumerator.h +++ b/evs/1.0/default/EvsEnumerator.h @@ -34,9 +34,9 @@ class EvsEnumerator : public IEvsEnumerator { public: // Methods from ::android::hardware::evs::V1_0::IEvsEnumerator follow. Return getCameraList(getCameraList_cb _hidl_cb) override; - Return openCamera(const hidl_string& cameraId, openCamera_cb callback) override; + Return> openCamera(const hidl_string& cameraId) override; Return closeCamera(const ::android::sp& carCamera) override; - Return openDisplay(openDisplay_cb callback) override; + Return> openDisplay() override; Return closeDisplay(const ::android::sp& display) override; // Implementation details diff --git a/gnss/1.0/default/Gnss.cpp b/gnss/1.0/default/Gnss.cpp index 66be37eb3b..5e6e65dcd2 100644 --- a/gnss/1.0/default/Gnss.cpp +++ b/gnss/1.0/default/Gnss.cpp @@ -385,7 +385,7 @@ Return Gnss::setPositionMode(IGnss::GnssPositionMode mode, preferredTimeMs) == 0); } -Return Gnss::getExtensionAGnssRil(getExtensionAGnssRil_cb _hidl_cb) { +Return> Gnss::getExtensionAGnssRil() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -397,11 +397,10 @@ Return Gnss::getExtensionAGnssRil(getExtensionAGnssRil_cb _hidl_cb) { mGnssRil = new AGnssRil(agpsRilIface); } } - _hidl_cb(mGnssRil); - return Void(); + return mGnssRil; } -Return Gnss::getExtensionGnssConfiguration(getExtensionGnssConfiguration_cb _hidl_cb) { +Return> Gnss::getExtensionGnssConfiguration() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -415,10 +414,9 @@ Return Gnss::getExtensionGnssConfiguration(getExtensionGnssConfiguration_c mGnssConfig = new GnssConfiguration(gnssConfigIface); } } - _hidl_cb(mGnssConfig); - return Void(); + return mGnssConfig; } -Return Gnss::getExtensionGnssGeofencing(getExtensionGnssGeofencing_cb _hidl_cb) { +Return> Gnss::getExtensionGnssGeofencing() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -433,11 +431,10 @@ Return Gnss::getExtensionGnssGeofencing(getExtensionGnssGeofencing_cb _hid } } - _hidl_cb(mGnssGeofencingIface); - return Void(); + return mGnssGeofencingIface; } -Return Gnss::getExtensionAGnss(getExtensionAGnss_cb _hidl_cb) { +Return> Gnss::getExtensionAGnss() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -449,11 +446,10 @@ Return Gnss::getExtensionAGnss(getExtensionAGnss_cb _hidl_cb) { mAGnssIface = new AGnss(agpsIface); } } - _hidl_cb(mAGnssIface); - return Void(); + return mAGnssIface; } -Return Gnss::getExtensionGnssNi(getExtensionGnssNi_cb _hidl_cb) { +Return> Gnss::getExtensionGnssNi() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -465,11 +461,10 @@ Return Gnss::getExtensionGnssNi(getExtensionGnssNi_cb _hidl_cb) { mGnssNi = new GnssNi(gpsNiIface); } } - _hidl_cb(mGnssNi); - return Void(); + return mGnssNi; } -Return Gnss::getExtensionGnssMeasurement(getExtensionGnssMeasurement_cb _hidl_cb) { +Return> Gnss::getExtensionGnssMeasurement() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -483,12 +478,10 @@ Return Gnss::getExtensionGnssMeasurement(getExtensionGnssMeasurement_cb _h mGnssMeasurement = new GnssMeasurement(gpsMeasurementIface); } } - _hidl_cb(mGnssMeasurement); - return Void(); + return mGnssMeasurement; } -Return Gnss::getExtensionGnssNavigationMessage( - getExtensionGnssNavigationMessage_cb _hidl_cb) { +Return> Gnss::getExtensionGnssNavigationMessage() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -504,11 +497,10 @@ Return Gnss::getExtensionGnssNavigationMessage( } } - _hidl_cb(mGnssNavigationMessage); - return Void(); + return mGnssNavigationMessage; } -Return Gnss::getExtensionXtra(getExtensionXtra_cb _hidl_cb) { +Return> Gnss::getExtensionXtra() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -522,11 +514,10 @@ Return Gnss::getExtensionXtra(getExtensionXtra_cb _hidl_cb) { } } - _hidl_cb(mGnssXtraIface); - return Void(); + return mGnssXtraIface; } -Return Gnss::getExtensionGnssDebug(getExtensionGnssDebug_cb _hidl_cb) { +Return> Gnss::getExtensionGnssDebug() { if (mGnssIface == nullptr) { ALOGE("%s: Gnss interface is unavailable", __func__); } else { @@ -540,8 +531,7 @@ Return Gnss::getExtensionGnssDebug(getExtensionGnssDebug_cb _hidl_cb) { } } - _hidl_cb(mGnssDebug); - return Void(); + return mGnssDebug; } IGnss* HIDL_FETCH_IGnss(const char* hal) { diff --git a/gnss/1.0/default/Gnss.h b/gnss/1.0/default/Gnss.h index a2c8676aff..e12ac128c9 100644 --- a/gnss/1.0/default/Gnss.h +++ b/gnss/1.0/default/Gnss.h @@ -74,16 +74,15 @@ struct Gnss : public IGnss { uint32_t minIntervalMs, uint32_t preferredAccuracyMeters, uint32_t preferredTimeMs) override; - Return getExtensionAGnssRil(getExtensionAGnssRil_cb _hidl_cb) override; - Return getExtensionGnssGeofencing(getExtensionGnssGeofencing_cb _hidl_cb) override; - Return getExtensionAGnss(getExtensionAGnss_cb _hidl_cb) override; - Return getExtensionGnssNi(getExtensionGnssNi_cb _hidl_cb) override; - Return getExtensionGnssMeasurement(getExtensionGnssMeasurement_cb _hidl_cb) override; - Return getExtensionGnssNavigationMessage( - getExtensionGnssNavigationMessage_cb _hidl_cb) override; - Return getExtensionXtra(getExtensionXtra_cb _hidl_cb) override; - Return getExtensionGnssDebug(getExtensionGnssDebug_cb _hidl_cb) override; - Return getExtensionGnssConfiguration(getExtensionGnssConfiguration_cb _hidl_cb) override; + Return> getExtensionAGnssRil() override; + Return> getExtensionGnssGeofencing() override; + Return> getExtensionAGnss() override; + Return> getExtensionGnssNi() override; + Return> getExtensionGnssMeasurement() override; + Return> getExtensionGnssNavigationMessage() override; + Return> getExtensionXtra() override; + Return> getExtensionGnssConfiguration() override; + Return> getExtensionGnssDebug() override; /* * Callback methods to be passed into the conventional GNSS HAL by the default