From 2c5a8716cdb9b011e60cb7d79d2f099f3058ae27 Mon Sep 17 00:00:00 2001 From: Yi Kong Date: Thu, 15 Aug 2024 14:28:14 +0800 Subject: [PATCH] graphics: Remove unnecessary std::move Moving a temporary object prevents copy elision, and could reduce performance. This fixes -Wpessimizing-move compiler warning. Test: presubmit Bug: 154270751 Change-Id: I26d488fb92bf3a9accc20d688da0408e6e19ca93 --- .../android/hardware/graphics/composer3/ComposerClientReader.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h b/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h index fbfac87f9d..e9d139d0bb 100644 --- a/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h +++ b/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h @@ -249,8 +249,7 @@ class ComposerClientReader { auto& data = mReturnData[displayLuts.display]; for (auto& lut : displayLuts.luts) { if (lut.pfd.get() >= 0) { - data.luts.push_back({lut.layer, - std::move(ndk::ScopedFileDescriptor(lut.pfd.release())), + data.luts.push_back({lut.layer, ndk::ScopedFileDescriptor(lut.pfd.release()), lut.lutProperties}); } }