diff --git a/audio/2.0/default/Android.mk b/audio/2.0/default/Android.mk index 8dec48209c..aa25077898 100644 --- a/audio/2.0/default/Android.mk +++ b/audio/2.0/default/Android.mk @@ -30,6 +30,8 @@ LOCAL_SRC_FILES := \ StreamIn.cpp \ StreamOut.cpp \ +LOCAL_CFLAGS := -Wall -Werror + LOCAL_SHARED_LIBRARIES := \ libbase \ libcutils \ @@ -65,6 +67,8 @@ LOCAL_PROPRIETARY_MODULE := true LOCAL_SRC_FILES := \ service.cpp +LOCAL_CFLAGS := -Wall -Werror + LOCAL_SHARED_LIBRARIES := \ libhidlbase \ libhidltransport \ diff --git a/audio/2.0/default/StreamIn.cpp b/audio/2.0/default/StreamIn.cpp index 9c933a9201..c074f3c928 100644 --- a/audio/2.0/default/StreamIn.cpp +++ b/audio/2.0/default/StreamIn.cpp @@ -87,7 +87,6 @@ void ReadThread::doRead() { } ssize_t readResult = mStream->read(mStream, &mBuffer[0], requestedToRead); mStatus.retval = Result::OK; - uint64_t read = 0; if (readResult >= 0) { mStatus.reply.read = readResult; if (!mDataMQ->write(&mBuffer[0], readResult)) { @@ -326,7 +325,7 @@ Return StreamIn::prepareForReading(uint32_t frameSize, ThreadInfo threadInfo = {0, 0}; // Wrap the _hidl_cb to return an error - auto sendError = [this, &threadInfo, &_hidl_cb](Result result) { + auto sendError = [&threadInfo, &_hidl_cb](Result result) { _hidl_cb(result, CommandMQ::Descriptor(), DataMQ::Descriptor(), StatusMQ::Descriptor(), threadInfo); diff --git a/audio/2.0/default/StreamOut.cpp b/audio/2.0/default/StreamOut.cpp index 22dcd0c994..0bedc74b62 100644 --- a/audio/2.0/default/StreamOut.cpp +++ b/audio/2.0/default/StreamOut.cpp @@ -302,7 +302,7 @@ Return StreamOut::prepareForWriting(uint32_t frameSize, ThreadInfo threadInfo = {0, 0}; // Wrap the _hidl_cb to return an error - auto sendError = [this, &threadInfo, &_hidl_cb](Result result) { + auto sendError = [&threadInfo, &_hidl_cb](Result result) { _hidl_cb(result, CommandMQ::Descriptor(), DataMQ::Descriptor(), StatusMQ::Descriptor(), threadInfo); diff --git a/audio/effect/2.0/default/Android.bp b/audio/effect/2.0/default/Android.bp index 79bb8b0d6b..e1072b466d 100644 --- a/audio/effect/2.0/default/Android.bp +++ b/audio/effect/2.0/default/Android.bp @@ -1,5 +1,6 @@ cc_library_shared { name: "android.hardware.audio.effect@2.0-impl", + defaults: ["hidl_defaults"], vendor: true, relative_install_path: "hw", srcs: [ diff --git a/audio/effect/2.0/default/Effect.cpp b/audio/effect/2.0/default/Effect.cpp index 2d36604d5b..184607e5df 100644 --- a/audio/effect/2.0/default/Effect.cpp +++ b/audio/effect/2.0/default/Effect.cpp @@ -610,10 +610,8 @@ Return Effect::getSupportedAuxChannelsConfigs( } Return Effect::getAuxChannelsConfig(getAuxChannelsConfig_cb _hidl_cb) { - uint32_t halCmd = EFFECT_FEATURE_AUX_CHANNELS; uint32_t halResult[alignedSizeIn(sizeof(uint32_t) + sizeof(channel_config_t))]; memset(halResult, 0, sizeof(halResult)); - uint32_t halResultSize = 0; EffectAuxChannelsConfig result; Result retval = getCurrentConfigImpl( EFFECT_FEATURE_AUX_CHANNELS,