diff --git a/radio/aidl/vts/AndroidTest.xml b/radio/aidl/vts/AndroidTest.xml new file mode 100644 index 0000000000..36381d1dd6 --- /dev/null +++ b/radio/aidl/vts/AndroidTest.xml @@ -0,0 +1,34 @@ + + + + \ No newline at end of file diff --git a/radio/aidl/vts/radio_aidl_hal_utils.cpp b/radio/aidl/vts/radio_aidl_hal_utils.cpp index 1f739302b4..861885111f 100644 --- a/radio/aidl/vts/radio_aidl_hal_utils.cpp +++ b/radio/aidl/vts/radio_aidl_hal_utils.cpp @@ -108,7 +108,7 @@ bool isVoiceEmergencyOnly(RegState state) { bool stringEndsWith(std::string const& string, std::string const& end) { if (string.size() >= end.size()) { - return (0 == string.compare(string.size() - end.size() - 1, end.size(), end)); + return std::equal(end.rbegin(), end.rend(), string.rbegin()); } else { return false; } @@ -117,7 +117,7 @@ bool stringEndsWith(std::string const& string, std::string const& end) { bool isServiceValidForDeviceConfiguration(std::string& serviceName) { if (isSsSsEnabled()) { // Device is configured as SSSS. - if (stringEndsWith(serviceName, RADIO_SERVICE_SLOT1_NAME)) { + if (!stringEndsWith(serviceName, RADIO_SERVICE_SLOT1_NAME)) { ALOGI("%s instance is not valid for SSSS device.", serviceName.c_str()); return false; } diff --git a/radio/aidl/vts/radio_config_test.cpp b/radio/aidl/vts/radio_config_test.cpp index a124907ad0..83c4de0090 100644 --- a/radio/aidl/vts/radio_config_test.cpp +++ b/radio/aidl/vts/radio_config_test.cpp @@ -24,11 +24,6 @@ void RadioConfigTest::SetUp() { std::string serviceName = GetParam(); - if (!isServiceValidForDeviceConfiguration(serviceName)) { - ALOGI("Skipped the test due to device configuration."); - GTEST_SKIP(); - } - radio_config = IRadioConfig::fromBinder( ndk::SpAIBinder(AServiceManager_waitForService(GetParam().c_str()))); ASSERT_NE(nullptr, radio_config.get());