diff --git a/radio/config/1.1/vts/functional/Android.bp b/radio/config/1.1/vts/functional/Android.bp index de909a3691..8cf7b629a5 100644 --- a/radio/config/1.1/vts/functional/Android.bp +++ b/radio/config/1.1/vts/functional/Android.bp @@ -29,5 +29,5 @@ cc_test { "android.hardware.radio.config@1.1", ], header_libs: ["radio.util.header@1.0"], - test_suites: ["general-tests"], + test_suites: ["general-tests", "vts-core"], } diff --git a/radio/config/1.1/vts/functional/VtsHalRadioConfigV1_1TargetTest.cpp b/radio/config/1.1/vts/functional/VtsHalRadioConfigV1_1TargetTest.cpp index 2fc6b62345..b3fae86a19 100644 --- a/radio/config/1.1/vts/functional/VtsHalRadioConfigV1_1TargetTest.cpp +++ b/radio/config/1.1/vts/functional/VtsHalRadioConfigV1_1TargetTest.cpp @@ -16,11 +16,7 @@ #include -int main(int argc, char** argv) { - ::testing::AddGlobalTestEnvironment(RadioConfigHidlEnvironment::Instance()); - ::testing::InitGoogleTest(&argc, argv); - RadioConfigHidlEnvironment::Instance()->init(&argc, argv); - int status = RUN_ALL_TESTS(); - LOG(INFO) << "Test result = " << status; - return status; -} +INSTANTIATE_TEST_SUITE_P( + PerInstance, RadioConfigHidlTest, + testing::ValuesIn(android::hardware::getAllHalInstanceNames(IRadioConfig::descriptor)), + android::hardware::PrintInstanceNameToString); diff --git a/radio/config/1.1/vts/functional/radio_config_hidl_hal_api.cpp b/radio/config/1.1/vts/functional/radio_config_hidl_hal_api.cpp index 5d0e867402..49c7aadf6b 100644 --- a/radio/config/1.1/vts/functional/radio_config_hidl_hal_api.cpp +++ b/radio/config/1.1/vts/functional/radio_config_hidl_hal_api.cpp @@ -21,7 +21,7 @@ /* * Test IRadioConfig.getModemsConfig() */ -TEST_F(RadioConfigHidlTest, getModemsConfig) { +TEST_P(RadioConfigHidlTest, getModemsConfig) { serial = GetRandomSerialNumber(); Return res = radioConfig->getModemsConfig(serial); ASSERT_OK(res); @@ -37,7 +37,7 @@ TEST_F(RadioConfigHidlTest, getModemsConfig) { /* * Test IRadioConfig.setModemsConfig() */ -TEST_F(RadioConfigHidlTest, setModemsConfig_invalidArgument) { +TEST_P(RadioConfigHidlTest, setModemsConfig_invalidArgument) { serial = GetRandomSerialNumber(); ModemsConfig* mConfig = new ModemsConfig(); Return res = radioConfig->setModemsConfig(serial, *mConfig); @@ -55,7 +55,7 @@ TEST_F(RadioConfigHidlTest, setModemsConfig_invalidArgument) { /* * Test IRadioConfig.setModemsConfig() */ -TEST_F(RadioConfigHidlTest, setModemsConfig_goodRequest) { +TEST_P(RadioConfigHidlTest, setModemsConfig_goodRequest) { serial = GetRandomSerialNumber(); ModemsConfig* mConfig = new ModemsConfig(); mConfig->numOfLiveModems = 1; @@ -73,7 +73,7 @@ TEST_F(RadioConfigHidlTest, setModemsConfig_goodRequest) { /* * Test IRadioConfig.getPhoneCapability() */ -TEST_F(RadioConfigHidlTest, getPhoneCapability) { +TEST_P(RadioConfigHidlTest, getPhoneCapability) { serial = GetRandomSerialNumber(); Return res = radioConfig->getPhoneCapability(serial); ASSERT_OK(res); @@ -99,7 +99,7 @@ TEST_F(RadioConfigHidlTest, getPhoneCapability) { /* * Test IRadioConfig.getPhoneCapability() */ -TEST_F(RadioConfigHidlTest, setPreferredDataModem) { +TEST_P(RadioConfigHidlTest, setPreferredDataModem) { serial = GetRandomSerialNumber(); Return res = radioConfig->getPhoneCapability(serial); ASSERT_OK(res); @@ -141,7 +141,7 @@ TEST_F(RadioConfigHidlTest, setPreferredDataModem) { /* * Test IRadioConfig.getPhoneCapability() */ -TEST_F(RadioConfigHidlTest, setPreferredDataModem_invalidArgument) { +TEST_P(RadioConfigHidlTest, setPreferredDataModem_invalidArgument) { serial = GetRandomSerialNumber(); uint8_t modemId = -1; Return res = radioConfig->setPreferredDataModem(serial, modemId); diff --git a/radio/config/1.1/vts/functional/radio_config_hidl_hal_test.cpp b/radio/config/1.1/vts/functional/radio_config_hidl_hal_test.cpp index 39e6487410..2e5e42456a 100644 --- a/radio/config/1.1/vts/functional/radio_config_hidl_hal_test.cpp +++ b/radio/config/1.1/vts/functional/radio_config_hidl_hal_test.cpp @@ -17,14 +17,10 @@ #include void RadioConfigHidlTest::SetUp() { - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); if (radioConfig == NULL) { sleep(60); - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); } ASSERT_NE(nullptr, radioConfig.get()); diff --git a/radio/config/1.1/vts/functional/radio_config_hidl_hal_utils.h b/radio/config/1.1/vts/functional/radio_config_hidl_hal_utils.h index c980901014..e9951dcad8 100644 --- a/radio/config/1.1/vts/functional/radio_config_hidl_hal_utils.h +++ b/radio/config/1.1/vts/functional/radio_config_hidl_hal_utils.h @@ -16,8 +16,6 @@ #include -#include -#include #include #include #include @@ -25,6 +23,9 @@ #include #include #include +#include +#include +#include #include "vts_test_util.h" @@ -73,22 +74,8 @@ class RadioConfigResponse : public IRadioConfigResponse { Return setModemsConfigResponse(const RadioResponseInfo& info); }; -// Test environment for Radio HIDL HAL. -class RadioConfigHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase { - public: - // get the test environment singleton - static RadioConfigHidlEnvironment* Instance() { - static RadioConfigHidlEnvironment* instance = new RadioConfigHidlEnvironment; - return instance; - } - virtual void registerTestServices() override { registerTestService(); } - - private: - RadioConfigHidlEnvironment() {} -}; - // The main test class for Radio config HIDL. -class RadioConfigHidlTest : public ::testing::VtsHalHidlTargetTestBase { +class RadioConfigHidlTest : public ::testing::TestWithParam { protected: std::mutex mtx_; std::condition_variable cv_; diff --git a/radio/config/1.2/vts/functional/Android.bp b/radio/config/1.2/vts/functional/Android.bp index 0cafc24160..2c2073a214 100644 --- a/radio/config/1.2/vts/functional/Android.bp +++ b/radio/config/1.2/vts/functional/Android.bp @@ -31,5 +31,5 @@ cc_test { "android.hardware.radio.config@1.2", ], header_libs: ["radio.util.header@1.0"], - test_suites: ["general-tests"], + test_suites: ["general-tests", "vts-core"], } diff --git a/radio/config/1.2/vts/functional/VtsHalRadioConfigV1_2TargetTest.cpp b/radio/config/1.2/vts/functional/VtsHalRadioConfigV1_2TargetTest.cpp index ec6544e659..f09ac3adc4 100644 --- a/radio/config/1.2/vts/functional/VtsHalRadioConfigV1_2TargetTest.cpp +++ b/radio/config/1.2/vts/functional/VtsHalRadioConfigV1_2TargetTest.cpp @@ -16,11 +16,7 @@ #include -int main(int argc, char** argv) { - ::testing::AddGlobalTestEnvironment(RadioConfigHidlEnvironment::Instance()); - ::testing::InitGoogleTest(&argc, argv); - RadioConfigHidlEnvironment::Instance()->init(&argc, argv); - int status = RUN_ALL_TESTS(); - LOG(INFO) << "Test result = " << status; - return status; -} +INSTANTIATE_TEST_SUITE_P( + PerInstance, RadioConfigHidlTest, + testing::ValuesIn(android::hardware::getAllHalInstanceNames(IRadioConfig::descriptor)), + android::hardware::PrintInstanceNameToString); diff --git a/radio/config/1.2/vts/functional/radio_config_hidl_hal_api.cpp b/radio/config/1.2/vts/functional/radio_config_hidl_hal_api.cpp index a3729aca2f..2129ecdb5c 100644 --- a/radio/config/1.2/vts/functional/radio_config_hidl_hal_api.cpp +++ b/radio/config/1.2/vts/functional/radio_config_hidl_hal_api.cpp @@ -21,7 +21,7 @@ /* * Test IRadioConfig.getSimSlotsStatus() */ -TEST_F(RadioConfigHidlTest, getSimSlotsStatus) { +TEST_P(RadioConfigHidlTest, getSimSlotsStatus) { const int serial = GetRandomSerialNumber(); Return res = radioConfig->getSimSlotsStatus(serial); ASSERT_OK(res); diff --git a/radio/config/1.2/vts/functional/radio_config_hidl_hal_test.cpp b/radio/config/1.2/vts/functional/radio_config_hidl_hal_test.cpp index cd7a1726aa..fd344b06ed 100644 --- a/radio/config/1.2/vts/functional/radio_config_hidl_hal_test.cpp +++ b/radio/config/1.2/vts/functional/radio_config_hidl_hal_test.cpp @@ -17,14 +17,10 @@ #include void RadioConfigHidlTest::SetUp() { - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); if (radioConfig == NULL) { sleep(60); - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); } ASSERT_NE(nullptr, radioConfig.get()); diff --git a/radio/config/1.2/vts/functional/radio_config_hidl_hal_utils.h b/radio/config/1.2/vts/functional/radio_config_hidl_hal_utils.h index a876766b48..e9cbcbd10e 100644 --- a/radio/config/1.2/vts/functional/radio_config_hidl_hal_utils.h +++ b/radio/config/1.2/vts/functional/radio_config_hidl_hal_utils.h @@ -16,8 +16,6 @@ #include -#include -#include #include #include #include @@ -27,6 +25,9 @@ #include #include #include +#include +#include +#include #include "vts_test_util.h" @@ -112,7 +113,7 @@ class RadioConfigHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase }; // The main test class for Radio config HIDL. -class RadioConfigHidlTest : public ::testing::VtsHalHidlTargetTestBase { +class RadioConfigHidlTest : public ::testing::TestWithParam { protected: std::mutex mtx_; std::condition_variable cv_;