Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:23:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use final specifier for all effects implementation classes.

Browse Source 
Avoid inherit from effect implementation class, all
implmentations should inherit EffectImpl directly.

Bug: 255361653
Test: atest VtsHalAudioEffectTargetTest
atest VtsHalAudioEffectFactoryTargetTest
atest VtsHalEqualizerTargetTest

Change-Id: I3c3bd990423be21f2c79f0e797d71b2d7f850dca
This commit is contained in:
Shunkai Yao
2022-11-02 00:21:02 +00:00
parent 6acc2e59f4
commit 6755d76d9d
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
audio/aidl/default/bassboost/BassBoostSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class BassBoostSwContext : public EffectContext {
class BassBoostSwContext final : public EffectContext {
public:
BassBoostSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class BassBoostSwContext : public EffectContext {
// TODO: add specific context here
};
class BassBoostSw : public EffectImpl {
class BassBoostSw final : public EffectImpl {
public:
BassBoostSw() { LOG(DEBUG) << __func__; }
~BassBoostSw() {

4
audio/aidl/default/dynamicProcessing/DynamicsProcessingSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class DynamicsProcessingSwContext : public EffectContext {
class DynamicsProcessingSwContext final : public EffectContext {
public:
DynamicsProcessingSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class DynamicsProcessingSwContext : public EffectContext {
// TODO: add specific context here
};
class DynamicsProcessingSw : public EffectImpl {
class DynamicsProcessingSw final : public EffectImpl {
public:
DynamicsProcessingSw() { LOG(DEBUG) << __func__; }
~DynamicsProcessingSw() {

4
audio/aidl/default/hapticGenerator/HapticGeneratorSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class HapticGeneratorSwContext : public EffectContext {
class HapticGeneratorSwContext final : public EffectContext {
public:
HapticGeneratorSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class HapticGeneratorSwContext : public EffectContext {
// TODO: add specific context here
};
class HapticGeneratorSw : public EffectImpl {
class HapticGeneratorSw final : public EffectImpl {
public:
HapticGeneratorSw() { LOG(DEBUG) << __func__; }
~HapticGeneratorSw() {

4
audio/aidl/default/loudnessEnhancer/LoudnessEnhancerSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class LoudnessEnhancerSwContext : public EffectContext {
class LoudnessEnhancerSwContext final : public EffectContext {
public:
LoudnessEnhancerSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class LoudnessEnhancerSwContext : public EffectContext {
// TODO: add specific context here
};
class LoudnessEnhancerSw : public EffectImpl {
class LoudnessEnhancerSw final : public EffectImpl {
public:
LoudnessEnhancerSw() { LOG(DEBUG) << __func__; }
~LoudnessEnhancerSw() {

4
audio/aidl/default/reverb/ReverbSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class ReverbSwContext : public EffectContext {
class ReverbSwContext final : public EffectContext {
public:
ReverbSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class ReverbSwContext : public EffectContext {
// TODO: add specific context here
};
class ReverbSw : public EffectImpl {
class ReverbSw final : public EffectImpl {
public:
ReverbSw() { LOG(DEBUG) << __func__; }
~ReverbSw() {

4
audio/aidl/default/virtualizer/VirtualizerSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class VirtualizerSwContext : public EffectContext {
class VirtualizerSwContext final : public EffectContext {
public:
VirtualizerSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class VirtualizerSwContext : public EffectContext {
// TODO: add specific context here
};
class VirtualizerSw : public EffectImpl {
class VirtualizerSw final : public EffectImpl {
public:
VirtualizerSw() { LOG(DEBUG) << __func__; }
~VirtualizerSw() {

4
audio/aidl/default/visualizer/VisualizerSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class VisualizerSwContext : public EffectContext {
class VisualizerSwContext final : public EffectContext {
public:
VisualizerSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class VisualizerSwContext : public EffectContext {
// TODO: add specific context here
};
class VisualizerSw : public EffectImpl {
class VisualizerSw final : public EffectImpl {
public:
VisualizerSw() { LOG(DEBUG) << __func__; }
~VisualizerSw() {

4
audio/aidl/default/volume/VolumeSw.h
View File

@@ -26,7 +26,7 @@
namespace aidl::android::hardware::audio::effect {
class VolumeSwContext : public EffectContext {
class VolumeSwContext final : public EffectContext {
public:
VolumeSwContext(int statusDepth, const Parameter::Common& common)
: EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class VolumeSwContext : public EffectContext {
// TODO: add specific context here
};
class VolumeSw : public EffectImpl {
class VolumeSw final : public EffectImpl {
public:
VolumeSw() { LOG(DEBUG) << __func__; }
~VolumeSw() {