From 120aa0837fb5649a3b2d129955d5981377626e85 Mon Sep 17 00:00:00 2001 From: Jaideep Sharma Date: Mon, 8 Jul 2024 14:55:42 +0530 Subject: [PATCH] vts: skip data path reverb tests on offload effects Skip the data path tests for offloading reverb, as offloading effects don't publish fmqs and don't actually process the data. Test: VtsHalEnvironmentalReverbTargetTest Bug: 351751648 Change-Id: Ib5f37c4568d405c6c597eb27fe216e6e345a2eae --- .../VtsHalEnvironmentalReverbTargetTest.cpp | 36 +++++++++++++++---- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/audio/aidl/vts/VtsHalEnvironmentalReverbTargetTest.cpp b/audio/aidl/vts/VtsHalEnvironmentalReverbTargetTest.cpp index 82a194e287..e31aae6645 100644 --- a/audio/aidl/vts/VtsHalEnvironmentalReverbTargetTest.cpp +++ b/audio/aidl/vts/VtsHalEnvironmentalReverbTargetTest.cpp @@ -353,8 +353,14 @@ class EnvironmentalReverbDataTest mInput.resize(kBufferSize); generateSineWaveInput(mInput); } - void SetUp() override { SetUpReverb(); } - void TearDown() override { TearDownReverb(); } + void SetUp() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + SetUpReverb(); + } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownReverb(); + } void assertEnergyIncreasingWithParameter(bool bypass) { createEnvParam(EnvironmentalReverb::bypass, bypass); @@ -418,12 +424,16 @@ class EnvironmentalReverbMinimumParamTest std::tie(mTag, mValue) = std::get(GetParam()); } void SetUp() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); SetUpReverb(); createEnvParam(EnvironmentalReverb::roomLevelMb, kMinRoomLevel); ASSERT_NO_FATAL_FAILURE( setAndVerifyParam(EX_NONE, mEnvParam, EnvironmentalReverb::roomLevelMb)); } - void TearDown() override { TearDownReverb(); } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownReverb(); + } EnvironmentalReverb::Tag mTag; int mValue; @@ -469,8 +479,14 @@ class EnvironmentalReverbDiffusionTest mInput.resize(kBufferSize); generateSineWaveInput(mInput); } - void SetUp() override { SetUpReverb(); } - void TearDown() override { TearDownReverb(); } + void SetUp() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + SetUpReverb(); + } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownReverb(); + } float getMean(std::vector& buffer) { return std::accumulate(buffer.begin(), buffer.end(), 0.0) / buffer.size(); @@ -543,8 +559,14 @@ class EnvironmentalReverbDensityTest generateSineWaveInput(mInput); } } - void SetUp() override { SetUpReverb(); } - void TearDown() override { TearDownReverb(); } + void SetUp() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + SetUpReverb(); + } + void TearDown() override { + SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags); + TearDownReverb(); + } EnvironmentalReverb::Tag mTag; int mParamValues;