From ac4edf053e6862477b6269e96b4e19738c96643d Mon Sep 17 00:00:00 2001 From: Kai Date: Tue, 23 Apr 2019 13:20:09 -0700 Subject: [PATCH] Update VHAL documentation Clarify when range in VehcileAreaConfig need to be specified. Change Range_remaining to be read only. Update docmentation about Night Mode. Bug: 126908895 Bug: 128607457 Test: Flash and build Change-Id: Ifcf92bcc9eed3859d8a846d55e824c2b00d61d19 --- automotive/vehicle/2.0/types.hal | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/automotive/vehicle/2.0/types.hal b/automotive/vehicle/2.0/types.hal index b04d0962c4..91197a55c9 100644 --- a/automotive/vehicle/2.0/types.hal +++ b/automotive/vehicle/2.0/types.hal @@ -641,7 +641,9 @@ enum VehicleProperty : int32_t { /** * Night mode * - * True indicates that night mode is currently enabled. + * True indicates that the night mode sensor has detected that the car cabin environment has + * low light. The platform could use this, for example, to enable appropriate UI for + * better viewing in dark or low light environments. * * @change_mode VehiclePropertyChangeMode:ON_CHANGE * @access VehiclePropertyAccess:READ @@ -983,6 +985,10 @@ enum VehicleProperty : int32_t { * * Indicates whether the vehicle is displaying temperature to the user as * Celsius or Fahrenheit. + * VehiclePropConfig.configArray is used to indicate the supported temperature display units. + * For example: configArray[0] = CELSIUS + * configArray[1] = FAHRENHEIT + * * This parameter MAY be used for displaying any HVAC temperature in the system. * Values must be one of VehicleUnit::CELSIUS or VehicleUnit::FAHRENHEIT * Note that internally, all temperatures are represented in floating point Celsius. @@ -2770,6 +2776,14 @@ struct VehicleAreaConfig { */ int32_t areaId; + /** + * If the property has @data_enum, leave the range to zero. + * + * Range will be ignored in the following cases: + * - The VehiclePropertyType is not INT32, INT64 or FLOAT. + * - Both of min value and max value are zero. + */ + int32_t minInt32Value; int32_t maxInt32Value;