Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Audio HAL: Fix UAF if the effect is removed after close

Browse Source 
am: 532240f4eb

Change-Id: I3a6ce3da68a1be76858f936d437860503b93c03b
This commit is contained in:
Mikhail Naganov
2019-12-04 17:34:44 -08:00
committed by android-build-merger
parent 7216c1bb33 532240f4eb
commit 78836599d2
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
audio/effect/all-versions/default/Effect.cpp
View File

@@ -713,7 +713,10 @@ Return<Result> Effect::close() {
#elif MAJOR_VERSION >= 6
// No need to join the processing thread, it is part of the API contract that the client
// must finish processing before closing the effect.
return analyzeStatus("EffectRelease", "", sContextCallFunction, EffectRelease(mHandle));
Result retval =
analyzeStatus("EffectRelease", "", sContextCallFunction, EffectRelease(mHandle));
EffectMap::getInstance().remove(mHandle);
return retval;
#endif
}