From 790db1074c92cc682c0da7fcdf454bd5e36f93fb Mon Sep 17 00:00:00 2001 From: Hridya Valsaraju Date: Tue, 10 Jan 2017 08:58:23 -0800 Subject: [PATCH] Use MQDescriptor typedefs for cleanup Test: mm Bug: 33815422 Change-Id: I41ca833231622a5a72970014cfcac400b512e44a --- audio/2.0/default/StreamIn.cpp | 8 ++++---- audio/2.0/default/StreamOut.cpp | 8 ++++---- graphics/composer/2.1/default/HwcClient.cpp | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/audio/2.0/default/StreamIn.cpp b/audio/2.0/default/StreamIn.cpp index 51c2cc72c0..edc8f128f4 100644 --- a/audio/2.0/default/StreamIn.cpp +++ b/audio/2.0/default/StreamIn.cpp @@ -275,7 +275,7 @@ Return StreamIn::prepareForReading( if (mDataMQ) { ALOGE("the client attempts to call prepareForReading twice"); _hidl_cb(Result::INVALID_STATE, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } std::unique_ptr tempDataMQ( @@ -285,7 +285,7 @@ Return StreamIn::prepareForReading( ALOGE_IF(!tempDataMQ->isValid(), "data MQ is invalid"); ALOGE_IF(!tempStatusMQ->isValid(), "status MQ is invalid"); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } // TODO: Remove event flag management once blocking MQ is implemented. b/33815422 @@ -293,7 +293,7 @@ Return StreamIn::prepareForReading( if (status != OK || !mEfGroup) { ALOGE("failed creating event flag for data MQ: %s", strerror(-status)); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } @@ -309,7 +309,7 @@ Return StreamIn::prepareForReading( if (status != OK) { ALOGW("failed to start reader thread: %s", strerror(-status)); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } diff --git a/audio/2.0/default/StreamOut.cpp b/audio/2.0/default/StreamOut.cpp index 4bb22742db..69da59ea48 100644 --- a/audio/2.0/default/StreamOut.cpp +++ b/audio/2.0/default/StreamOut.cpp @@ -263,7 +263,7 @@ Return StreamOut::prepareForWriting( if (mDataMQ) { ALOGE("the client attempts to call prepareForWriting twice"); _hidl_cb(Result::INVALID_STATE, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } std::unique_ptr tempDataMQ( @@ -273,7 +273,7 @@ Return StreamOut::prepareForWriting( ALOGE_IF(!tempDataMQ->isValid(), "data MQ is invalid"); ALOGE_IF(!tempStatusMQ->isValid(), "status MQ is invalid"); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } // TODO: Remove event flag management once blocking MQ is implemented. b/33815422 @@ -281,7 +281,7 @@ Return StreamOut::prepareForWriting( if (status != OK || !mEfGroup) { ALOGE("failed creating event flag for data MQ: %s", strerror(-status)); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } @@ -297,7 +297,7 @@ Return StreamOut::prepareForWriting( if (status != OK) { ALOGW("failed to start writer thread: %s", strerror(-status)); _hidl_cb(Result::INVALID_ARGUMENTS, - MQDescriptorSync(), MQDescriptorSync()); + DataMQ::Descriptor(), StatusMQ::Descriptor()); return Void(); } diff --git a/graphics/composer/2.1/default/HwcClient.cpp b/graphics/composer/2.1/default/HwcClient.cpp index 54dfd89228..621cb14a33 100644 --- a/graphics/composer/2.1/default/HwcClient.cpp +++ b/graphics/composer/2.1/default/HwcClient.cpp @@ -514,7 +514,7 @@ Return HwcClient::getOutputCommandQueue( if (outDescriptor) { hidl_cb(Error::NONE, *outDescriptor); } else { - hidl_cb(Error::NO_RESOURCES, MQDescriptorSync()); + hidl_cb(Error::NO_RESOURCES, CommandQueueType::Descriptor()); } return Void();