diff --git a/health/utils/libhealth2impl/BinderHealth.cpp b/health/utils/libhealth2impl/BinderHealth.cpp index 625d0e0c40..8ec8962175 100644 --- a/health/utils/libhealth2impl/BinderHealth.cpp +++ b/health/utils/libhealth2impl/BinderHealth.cpp @@ -35,10 +35,9 @@ namespace health { namespace V2_1 { namespace implementation { -bool IsDeadObjectLogged(const Return& ret) { +bool IsDeadObject(const Return& ret) { if (ret.isOk()) return false; if (ret.isDeadObject()) return true; - LOG(ERROR) << "Cannot call healthInfoChanged* on callback: " << ret.description(); return false; } @@ -77,7 +76,7 @@ Return BinderHealth::registerCallback(const spNotify(health_info); - if (IsDeadObjectLogged(ret)) { + if (IsDeadObject(ret)) { // Remove callback reference. std::lock_guard lock(callbacks_lock_); auto it = std::find_if(callbacks_.begin(), callbacks_.end(), @@ -133,7 +132,7 @@ void BinderHealth::OnHealthInfoChanged(const HealthInfo& health_info) { std::unique_lock lock(callbacks_lock_); for (auto it = callbacks_.begin(); it != callbacks_.end();) { auto ret = (*it)->Notify(health_info); - if (IsDeadObjectLogged(ret)) { + if (IsDeadObject(ret)) { it = callbacks_.erase(it); } else { ++it;