From 0dbb9903cd8b414ca16f6b4bb379bfcadecea0a5 Mon Sep 17 00:00:00 2001 From: Martijn Coenen Date: Thu, 15 Dec 2016 21:34:38 +0100 Subject: [PATCH] Revert "Fix tests for using IBase instead of IBinder." This reverts commit 1d747311b3aa3d208aedf3dfce97d134d57db723. Bug: 33173166 Test: builds, hidl_test --- tests/bar/1.0/default/Bar.cpp | 28 +--------------------------- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/tests/bar/1.0/default/Bar.cpp b/tests/bar/1.0/default/Bar.cpp index a9b6c25ff8..a750fe41e6 100644 --- a/tests/bar/1.0/default/Bar.cpp +++ b/tests/bar/1.0/default/Bar.cpp @@ -122,36 +122,10 @@ Return Bar::haveAVectorOfInterfaces( return Void(); } -// TODO: remove after b/33173166 is fixed. -struct Simple : public ISimple { - Simple(int32_t cookie) - : mCookie(cookie) { - } - - Return getCookie() override { - return mCookie; - } - -private: - int32_t mCookie; -}; - -// TODO: use _hidl_cb(in) after b/33173166 is fixed. Return Bar::haveAVectorOfGenericInterfaces( const hidl_vec > &in, haveAVectorOfGenericInterfaces_cb _hidl_cb) { - // _hidl_cb(in); - hidl_vec > out; - out.resize(in.size()); - for (size_t i = 0; i < in.size(); ++i) { - sp s = ISimple::castFrom(in[i]); - if (s.get() == nullptr) { - out[i] = new Simple(-1); - } else { - out[i] = new Simple(s->getCookie()); - } - } - _hidl_cb(out); + _hidl_cb(in); return Void(); }