From 876220fe511633280c5ca8bdf7430eb41f9c9a7d Mon Sep 17 00:00:00 2001 From: Roshan Pius Date: Thu, 28 Dec 2017 16:19:06 -0800 Subject: [PATCH] wifi(implementation): Fix IWifiChip.getCapabilities() Some non-pixel devices don't support the logger API's, bypass the error check for these devices. This is already done for IWifiStaIface.getCapabilities(), but was missing in IWifiChip.getCapabilities(). Bug: 69094019 Test: Compiles Change-Id: I1c5be66b9f22461a957321a83332152ec2cd0c6d --- wifi/1.2/default/wifi_chip.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wifi/1.2/default/wifi_chip.cpp b/wifi/1.2/default/wifi_chip.cpp index adba054e2d..8d9cfc6188 100644 --- a/wifi/1.2/default/wifi_chip.cpp +++ b/wifi/1.2/default/wifi_chip.cpp @@ -387,7 +387,8 @@ std::pair WifiChip::getCapabilitiesInternal() { std::tie(legacy_status, legacy_logger_feature_set) = legacy_hal_.lock()->getLoggerSupportedFeatureSet(getWlan0IfaceName()); if (legacy_status != legacy_hal::WIFI_SUCCESS) { - return {createWifiStatusFromLegacyError(legacy_status), 0}; + // some devices don't support querying logger feature set + legacy_logger_feature_set = 0; } uint32_t hidl_caps; if (!hidl_struct_util::convertLegacyFeaturesToHidlChipCapabilities(