From 8e9ac0249a10d1cced36bebaa0c5a044658f1f9a Mon Sep 17 00:00:00 2001 From: Austin Borger Date: Thu, 4 May 2023 11:17:26 -0700 Subject: [PATCH] Camera VTS: Close the session at the end of stream configuration validation Not calling mSession->close means that there will be multiple concurrent sessions open, which may not be supported by the device. Bug: 280559094 Test: Ran on cuttlefish Change-Id: Ie622fabd4d0be2f8442e90d1c781bbf905172270 --- .../aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp index 622b20b094..f8d301f081 100644 --- a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp +++ b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp @@ -3081,7 +3081,11 @@ TEST_P(CameraAidlTest, validateStreamConfigurations) { ASSERT_EQ(blobMinDurations.size(), blobStallDurations.size()); } - // Validate other aspects of stream configuration metadata... + // TODO (b/280887191): Validate other aspects of stream configuration metadata... + + ndk::ScopedAStatus ret = mSession->close(); + mSession = nullptr; + ASSERT_TRUE(ret.isOk()); } }