Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Effect: Move thread priority updates from threadLoop" into tm-qpr-dev

Browse Source
This commit is contained in:
Andy Hung
2023-01-12 23:39:15 +00:00
committed by Android (Google) Code Review
parent df9ea6e679 cbde2d0940
commit 8f12fe9000
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
audio/effect/all-versions/default/Effect.cpp
View File

@@ -240,16 +240,6 @@ class ProcessThread : public Thread {
};
bool ProcessThread::threadLoop() {
// For a spatializer effect, we perform scheduler adjustments to reduce glitches and power.
{
effect_descriptor_t halDescriptor{};
if ((*mEffect)->get_descriptor(mEffect, &halDescriptor) == NO_ERROR &&
memcmp(&halDescriptor.type, FX_IID_SPATIALIZER, sizeof(effect_uuid_t)) == 0) {
const status_t status = scheduler::updateSpatializerPriority(gettid());
ALOGW_IF(status != OK, "Failed to update Spatializer priority");
}
}
// This implementation doesn't return control back to the Thread until it decides to stop,
// as the Thread uses mutexes, and this can lead to priority inversion.
while (!std::atomic_load_explicit(mStop, std::memory_order_acquire)) {
@@ -570,6 +560,15 @@ Return<void> Effect::prepareForProcessing(prepareForProcessing_cb _hidl_cb) {
return Void();
}
// For a spatializer effect, we perform scheduler adjustments to reduce glitches and power.
// We do it here instead of the ProcessThread::threadLoop to ensure that mHandle is valid.
if (effect_descriptor_t halDescriptor{};
(*mHandle)->get_descriptor(mHandle, &halDescriptor) == NO_ERROR &&
memcmp(&halDescriptor.type, FX_IID_SPATIALIZER, sizeof(effect_uuid_t)) == 0) {
const status_t status = scheduler::updateSpatializerPriority(mProcessThread->getTid());
ALOGW_IF(status != OK, "Failed to update Spatializer priority");
}
mStatusMQ = std::move(tempStatusMQ);
_hidl_cb(Result::OK, *mStatusMQ->getDesc());
return Void();