Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Return INVALID_ ARGUMENTS is the expected result"

Browse Source
This commit is contained in:
Treehugger Robot
2023-07-06 05:15:52 +00:00
committed by Gerrit Code Review
parent 9bf3a09289 eddc6dc0ad
commit 97af8becd7
6 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
radio/1.0/vts/functional/vts_test_util.cpp
View File

@@ -138,3 +138,7 @@ std::cv_status RadioResponseWaiter::wait() {
count_--;
return status;
}
bool isLteConnected(){
return testing::checkSubstringInCommandOutput("getprop gsm.network.type", "LTE");
}

5
radio/1.0/vts/functional/vts_test_util.h
View File

@@ -104,6 +104,11 @@ bool isVoiceEmergencyOnly(RegState state);
*/
bool isVoiceInService(RegState state);
/*
* Check if device is in Lte Connected status.
*/
bool isLteConnected();
/**
* Used when waiting for an asynchronous response from the HAL.
*/

2
radio/1.5/vts/functional/radio_hidl_hal_api.cpp
View File

@@ -597,7 +597,7 @@ TEST_P(RadioHidlTest_v1_5, startNetworkScan) {
} else if (cardStatus.base.base.base.cardState == CardState::PRESENT) {
// Modems support 3GPP RAT family need to
// support scanning requests combined with some parameters.
if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM)) {
if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM) && isLteConnected()) {
ASSERT_TRUE(CheckAnyOfErrors(radioRsp_v1_5->rspInfo.error,
{RadioError::NONE, RadioError::OPERATION_NOT_ALLOWED}));
} else {

4
radio/aidl/vts/radio_aidl_hal_utils.cpp
View File

@@ -227,3 +227,7 @@ void RadioServiceTest::updateSimSlotStatus(int physicalSlotId) {
slotStatus = radioConfigRsp->simSlotStatus[physicalSlotId];
}
}
bool isLteConnected(){
return testing::checkSubstringInCommandOutput("getprop gsm.network.type", "LTE");
}

5
radio/aidl/vts/radio_aidl_hal_utils.h
View File

@@ -128,6 +128,11 @@ bool isVoiceInService(RegState state);
*/
bool isServiceValidForDeviceConfiguration(std::string& serviceName);
/*
* Check if device is in Lte Connected status.
*/
bool isLteConnected();
/**
* RadioServiceTest base class
*/

2
radio/aidl/vts/radio_network_test.cpp
View File

@@ -861,7 +861,7 @@ TEST_P(RadioNetworkTest, startNetworkScan) {
if (cardStatus.cardState == CardStatus::STATE_ABSENT) {
ASSERT_TRUE(CheckAnyOfErrors(radioRsp_network->rspInfo.error, {RadioError::SIM_ABSENT}));
} else if (cardStatus.cardState == CardStatus::STATE_PRESENT) {
if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM)) {
if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM) && isLteConnected()) {
// Modems support 3GPP RAT family need to
// support scanning requests combined with some parameters.
ASSERT_TRUE(CheckAnyOfErrors(radioRsp_network->rspInfo.error,