From 9fb755319bcca29be1470135c86da05290af3c29 Mon Sep 17 00:00:00 2001 From: Peiyong Lin Date: Wed, 14 Jun 2023 18:12:39 +0000 Subject: [PATCH] Avoid skipping test if it's supported. Previously the test will be skipped regardless whether setThreads is supported, this patch moves the check below and check the returned status code to determine whether the test should be skipped. Bug: b/287282833 Test: atest VtsHalPowerTargetTest Change-Id: I9ce6b4ead5e245478247903a75922ece74f38ee7 --- power/aidl/vts/VtsHalPowerTargetTest.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/power/aidl/vts/VtsHalPowerTargetTest.cpp b/power/aidl/vts/VtsHalPowerTargetTest.cpp index d14e7b61a6..c2216f8cf6 100644 --- a/power/aidl/vts/VtsHalPowerTargetTest.cpp +++ b/power/aidl/vts/VtsHalPowerTargetTest.cpp @@ -255,11 +255,10 @@ TEST_P(PowerAidl, setThreads) { } ASSERT_TRUE(status.isOk()); - if (mApiLevel < kCompatibilityMatrix8ApiLevel) { + status = session->setThreads(kEmptyTids); + if (mApiLevel < kCompatibilityMatrix8ApiLevel && isUnknownOrUnsupported(status)) { GTEST_SKIP() << "DEVICE not launching with Android 14 and beyond."; } - - status = session->setThreads(kEmptyTids); ASSERT_FALSE(status.isOk()); ASSERT_EQ(EX_ILLEGAL_ARGUMENT, status.getExceptionCode());