From fbbb209b6334c8e2d947f3e0c1f9651b017fbd95 Mon Sep 17 00:00:00 2001 From: Silver Chen Date: Fri, 13 May 2022 10:03:45 +0800 Subject: [PATCH] Fix VTS PlaybackDataFlowWithTsVideoFilterTest sometimes failed. [Description] If filter is started after playback thread, sometimes filter cannot get data correctly because of timing issue. Start playback thread after filter is started so that filter will always get data correctly. Bug: 235185563 Test: 1. Testcase pass Change-Id: I97c38dab1ff81c31b4bb48c8015b626b3a6325ed (cherry picked from commit 8ab7fd8b21b59e736cea26badb56e992debf0d4e) --- tv/tuner/1.0/vts/functional/VtsHalTvTunerV1_0TargetTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tv/tuner/1.0/vts/functional/VtsHalTvTunerV1_0TargetTest.cpp b/tv/tuner/1.0/vts/functional/VtsHalTvTunerV1_0TargetTest.cpp index 3e3a4d4732..59b7939833 100644 --- a/tv/tuner/1.0/vts/functional/VtsHalTvTunerV1_0TargetTest.cpp +++ b/tv/tuner/1.0/vts/functional/VtsHalTvTunerV1_0TargetTest.cpp @@ -144,9 +144,9 @@ void TunerPlaybackHidlTest::playbackSingleFilterTest(FilterConfig filterConf, Dv ASSERT_TRUE(mFilterTests.getNewlyOpenedFilterId(filterId)); ASSERT_TRUE(mFilterTests.configFilter(filterConf.settings, filterId)); ASSERT_TRUE(mFilterTests.getFilterMQDescriptor(filterId, filterConf.getMqDesc)); - mDvrTests.startPlaybackInputThread(dvrConf.playbackInputFile, dvrConf.settings.playback()); ASSERT_TRUE(mDvrTests.startDvrPlayback()); ASSERT_TRUE(mFilterTests.startFilter(filterId)); + mDvrTests.startPlaybackInputThread(dvrConf.playbackInputFile, dvrConf.settings.playback()); ASSERT_TRUE(filterDataOutputTest()); mDvrTests.stopPlaybackThread(); ASSERT_TRUE(mFilterTests.stopFilter(filterId));