From c7f5c2dd8389ddf84cb4836ae70038d1208a6289 Mon Sep 17 00:00:00 2001 From: Shunkai Yao Date: Tue, 13 Feb 2024 01:59:55 +0000 Subject: [PATCH] Effect AIDL: add Spatializer default implementation to Cuttlefish Bug: 273373363 Test: atest --test-mapping hardware/interfaces/audio/aidl/vts:presubmit Change-Id: Ib49d62c61de831c8147c935799d22be78950488f --- audio/aidl/default/apex/com.android.hardware.audio/Android.bp | 1 + audio/aidl/default/spatializer/Android.bp | 2 +- audio/aidl/default/spatializer/SpatializerSw.cpp | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/audio/aidl/default/apex/com.android.hardware.audio/Android.bp b/audio/aidl/default/apex/com.android.hardware.audio/Android.bp index 9c91e27220..2ece7a1929 100644 --- a/audio/aidl/default/apex/com.android.hardware.audio/Android.bp +++ b/audio/aidl/default/apex/com.android.hardware.audio/Android.bp @@ -38,6 +38,7 @@ apex { "libpreprocessingaidl", "libpresetreverbsw", "libreverbaidl", + "libspatializersw", "libvirtualizersw", "libvisualizeraidl", "libvolumesw", diff --git a/audio/aidl/default/spatializer/Android.bp b/audio/aidl/default/spatializer/Android.bp index 400629eb9b..2c229fe363 100644 --- a/audio/aidl/default/spatializer/Android.bp +++ b/audio/aidl/default/spatializer/Android.bp @@ -35,6 +35,6 @@ cc_library_shared { ], relative_install_path: "soundfx", visibility: [ - "//hardware/interfaces/audio/aidl/default", + "//hardware/interfaces/audio/aidl/default:__subpackages__", ], } diff --git a/audio/aidl/default/spatializer/SpatializerSw.cpp b/audio/aidl/default/spatializer/SpatializerSw.cpp index 6d3c4bd16e..ef86ddb2a1 100644 --- a/audio/aidl/default/spatializer/SpatializerSw.cpp +++ b/audio/aidl/default/spatializer/SpatializerSw.cpp @@ -108,6 +108,8 @@ ndk::ScopedAStatus SpatializerSw::setParameterSpecific(const Parameter::Specific ndk::ScopedAStatus SpatializerSw::getParameterSpecific(const Parameter::Id& id, Parameter::Specific* specific) { + RETURN_IF(!mContext, EX_NULL_POINTER, "nullContext"); + auto tag = id.getTag(); RETURN_IF(Parameter::Id::spatializerTag != tag, EX_ILLEGAL_ARGUMENT, "wrongIdTag"); auto spatializerId = id.get();